Arm backend: Annotate maximum/minimum ops w. independent observers#18009
Open
AdrianLundell wants to merge 1 commit intopytorch:mainfrom
Open
Arm backend: Annotate maximum/minimum ops w. independent observers#18009AdrianLundell wants to merge 1 commit intopytorch:mainfrom
AdrianLundell wants to merge 1 commit intopytorch:mainfrom
Conversation
Previous shared observers meant that inputs and outputs were all quantized within the same range. In cases where the output is heavily truncated, this left a lot of the output range unused, leading to unnecessarily poor accuracy. Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: If076f1ec58bbbb4b301259cd85a5dda99498cdc6
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18009
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Awaiting Approval, 10 New Failures, 12 PendingAs of commit 22f7610 with merge base 122fdef ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zingo
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous shared observers meant that inputs and outputs were all quantized within the same range. In cases where the output is heavily truncated, this left a lot of the output range unused, leading to unnecessarily poor accuracy.
cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell