Skip to content

Arm backend: Annotate maximum/minimum ops w. independent observers#18009

Open
AdrianLundell wants to merge 1 commit intopytorch:mainfrom
AdrianLundell:change-1214771
Open

Arm backend: Annotate maximum/minimum ops w. independent observers#18009
AdrianLundell wants to merge 1 commit intopytorch:mainfrom
AdrianLundell:change-1214771

Conversation

@AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Mar 9, 2026

Previous shared observers meant that inputs and outputs were all quantized within the same range. In cases where the output is heavily truncated, this left a lot of the output range unused, leading to unnecessarily poor accuracy.

cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Previous shared observers meant that inputs and outputs were all
quantized within the same range. In cases where the output is
heavily truncated, this left a lot of the output range unused,
leading to unnecessarily poor accuracy.

Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
Change-Id: If076f1ec58bbbb4b301259cd85a5dda99498cdc6
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Mar 9, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 9, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18009

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Awaiting Approval, 10 New Failures, 12 Pending

As of commit 22f7610 with merge base 122fdef (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants