WIP: Implement 'Links' functionality#337
Open
MartinFalatic wants to merge 1 commit intopyupio:masterfrom
Open
Conversation
MartinFalatic
force-pushed
the
dev-mff
branch
2 times, most recently
from
52106c2 to
6850742
Compare
This allows PyUp to retrieve and display links for a given package using the new `package_metadata` PyUp API. This provides greater parity with the Github Enterprise PyUp. Also added a dry run option to make live testing easier to accomplish
Contributor
|
Interesting work you made here. I would urge you to bring the dry-run as a separate pull-request to close #372 maybe. Even though that is not required, it would speed up discussing and merging separate subjects. Regarding the "links" idea, not sure I follow completely, but it sounds like a nice addition to the PR information. Is this still a work in progress? We made some changes on master, so you would need to rebase this as well. Looking forward your feedback! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows PyUp to retrieve and display links for a given package using
the new
package_metadataPyUp API.This provides greater parity with the Github Enterprise PyUp.