Repository navigation
Conversation
The 0.4 API is new, so sgai/ and the dashboard are rewritten for it:
- Connections take an Origin.Producer to publish and one to consume.
waitForBroadcast()/waitForAnnounced() wait with
origin.request(path, { announced: true }), with a plain timer for the
timeout: AbortSignal.any() with AbortSignal.timeout() could be
garbage-collected on Node 20 and stop the ad-break loop.
- The publisher creates its tracks up front. A new subscriber starts at
the newest group from its first frame, so the manual copy of the
current cycle's events is removed.
- Readers use track(name).subscribe(), and .ordered() to read frames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #9. Merge #8 and #9 first; this PR then moves to
main.What
@moq/net0.3.5 → 0.4.6 (root anddashboard/),@moq/msf0.2.2 → 0.3.1.patches/@moq__msf.patchis still needed.sgai/anddashboard/src/lib/monitor.jsrewritten for the new 0.4 API.Changes
Connection.connect({ url, publish, consume })withOrigin.Producers.sgai/transport.mjshaswaitForBroadcast()andwaitForAnnounced(), based onorigin.request(path, { announced: true }).AbortSignal.any()+AbortSignal.timeout(). On Node 20 the combined signal could be garbage-collected before it fired, and the ad-break loop stopped at the second break (seen while testing).createTrack(). A new subscriber starts at the newest group from its first frame, so the manual copy of the current cycle's events from fix: send each SGAI ad-break cycle as one group #8 is removed.track(name).subscribe(), with.ordered()to read frames (readFrameSequence()is gone).moq-lite-06.Tests
%token%.moq-lite-06), end-to-end latency ~290 ms.