Repository navigation
Conversation
The dashboard gets a Player card that plays the stream with @moq/watch. With --sgai-mode it reads the Event Timeline and switches to the ad broadcast named in Ad Start on Placement Opportunity Start, and back on Placement Opportunity End. A Program Blackout Override covers the picture. The card shows the latest events and how long each switch took. Every switch mounts a new <moq-watch>: changing name on one element reused its video pipeline, and the first frames of the new broadcast failed to decode, because content and ad share the track name 0.m4s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #11. Merge #8–#11 first; this PR then moves to
main.Why
Until now the sandbox only produced the SGAI signaling. The README said that a player that acts on it was "not included here", so the content → ad → content flow was never tested end to end.
What
dashboard/src/components/Player.jsx). It plays the stream with@moq/watch0.6.6 in every mode. Audio starts muted; there is an Unmute button.dashboard/src/lib/sgai.jsreads theeventstrack, one group per cycle, each group read to its end.Ad Startgives the ad broadcast (ns=in the upid).Placement Opportunity Startcloses the content subscription and plays the ad.Placement Opportunity Endgoes back to the content.Program Blackout Overridecovers the picture and shows the alternate upid.<moq-watch>. Changingnameon one element reused its video pipeline, and the first frames of the new broadcast failed to decode (EncodingError), because content and ad share the track name0.m4s. With one element per switch: no errors./api/configreturnseventsBroadcastin SGAI mode (<name>-events, asstream.shnames it). The CI dashboard job checks that it isnullin base mode.Tests
In Chrome, with Podman + the host Ad Decisioning Publisher (12 s content, 8 s ad):
namehad 3EncodingErrors per run).