fix collaborator query returning 0 due to exclude_pmids - #17
Merged
Conversation
…rompt * stop excluding qdrant-retrieved pmids from collaborator search since the goal is finding people, not new papers * tell the LLM to report empty tool results instead of hiding them * revert the neo4j result filtering so all tool outputs reach the summarizer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exclude_pmids. For authors with few papers (e.g. Richard D Kennedy, 2 papers), this excluded all relevant papers and returned 0 collaborators.get_related_papers_by_meshwhere it makes sense.Root cause
Richard D Kennedy has 2 papers. Paper 15547178 has BRCA1/Breast Neoplasms MeSH terms and 4 collaborators. But 15547178 was already in
exclude_pmids(returned by Qdrant), so the collaborator query had 0 matching papers left.Test plan