fix: use the canonical Hugging Face source for BGE-small - #707
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe BGE-small English model now references Priority: ⬇️ Low — Defer this narrow BGE-small source correction because it preserves the existing model behavior and only addresses a canonical Hugging Face repository identifier. Estimated code review effort: 1 (Trivial) | ~2 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to BGE-small now uses the canonical Hugging Face repository name, avoiding the redirect while preserving model settings and output dimensions. The updated source is covered by a regression test and targeted runtime validation, with no current merge-blocking risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you! |
Related to #706.
Use
Qdrant/bge-small-en-v1.5-onnx-Qas the Hugging Face source for the existingBAAI/bge-small-en-v1.5model. The public model name, model file, dimensions, and inference settings are unchanged.On September 8, I checked the initial HEAD responses for
config.json:X-Repo-Commitheader.X-Repo-Commitpresent.This removes the extra case-normalizing redirect described in #706. It does not eliminate all redirects or change Hugging Face Hub's redirect handling. I did not reproduce the reporter's specific macOS/proxy/huggingface-hub 1.29.0 environment.
The regression test checks the source exposed by
TextEmbedding.list_supported_models()and fails before the registry change. It is offline and does not download model weights.Validation on Windows / Python 3.14.4, with huggingface-hub 1.30.0 and ONNX Runtime 1.29.0:
python -m pytest tests/test_common.py -q: 4 passed.git diff --check: passed.local_files_only=True/HF_HUB_OFFLINE=1run succeeded from that cache.Compatibility note: the Hugging Face repository ID is part of the cache directory name. Existing caches populated using the lowercase ID may need a one-time download into the canonical namespace; offline-only deployments should prepare that cache before upgrading. This patch does not migrate or delete old caches.
PR #593 addresses the analogous source correction for BGE-base, not BGE-small; this patch intentionally leaves that entry untouched.
Prepared with AI assistance; the checks and smoke tests above were executed locally. This is a model-source metadata fix, not a model or embedding-quality change.
All Submissions