Skip to content

fix(local): compare score_threshold in the query's own score direction (#1370) #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anai-Guo wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(local): compare score_threshold in the query's own score direction (#1370) #1371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions qdrant_client/local/local_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,10 @@ def search(

required_order = distance_to_order(distance)

if required_order == DistanceOrder.BIGGER_IS_BETTER or isinstance(
# Recommend/discovery/context queries score through a sigmoid, so bigger is
# always better for them, whatever the collection's distance is. Both the sort
# order and the score_threshold comparison below have to follow this flag.
bigger_is_better = required_order == DistanceOrder.BIGGER_IS_BETTER or isinstance(
query_vector,
(
DiscoveryQuery,
Expand All @@ -664,7 +667,9 @@ def search(
MultiContextQuery,
MultiRecoQuery,
), # sparse structures are not required, sparse always uses DOT
):
)

if bigger_is_better:
order = np.argsort(scores)[::-1]
else:
order = np.argsort(scores)
Expand All @@ -684,7 +689,7 @@ def search(
point_id = self.ids_inv[idx]

if score_threshold is not None:
if required_order == DistanceOrder.BIGGER_IS_BETTER:
if bigger_is_better:
if score < score_threshold:
break
else:
Expand Down