Skip to content

Fix datetime_utils.parse accepting truncated datetimes #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TarunSinghChauhan wants to merge 1 commit into from
Closed

Fix datetime_utils.parse accepting truncated datetimes #1380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion qdrant_client/local/datetime_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import re
from datetime import datetime, timezone

# These are the formats accepted by qdrant core
Expand Down Expand Up @@ -46,4 +47,12 @@ def parse_available_formats(datetime_str: str) -> datetime | None:
# dt examples to handle:
# "2021-01-01 00:00:00.000+01"
# "2021-01-01 00:00:00.000-10"
return parse_available_formats(date_str + ":00")
# This retry must only fire for an actual hour-only UTC offset at the end of
# the string (e.g. "+01" or "-10"). Without this guard, any string that fails
# every format above (including truncated datetimes like "2024-06-15 12" or
# "2024-06-15T12:30") would also get ":00" appended and could accidentally
# match a valid format, silently accepting input that qdrant core rejects.
if re.search(r"[+-]\d{2}$", date_str):
return parse_available_formats(date_str + ":00")

return None