Skip to content

fix: show server error text, fix upload retry warning - #1409

Open
Goodnight77 wants to merge 1 commit into
qdrant:devfrom
Goodnight77:fix/error-display
Open

fix: show server error text, fix upload retry warning#1409
Goodnight77 wants to merge 1 commit into
qdrant:devfrom
Goodnight77:fix/error-display

Conversation

@Goodnight77

Copy link
Copy Markdown
Contributor

summary

fix: show server error text in UnexpectedResponse and fix upload retry warning

  • UnexpectedResponse.__str__ now prints the status.error text from the qdrant json body instead of raw bytes cut at 200 chars. falls back to the old raw output if the body is not json. .content and .structured() unchanged
  • in rest_uploader.py and grpc_uploader.py the retry loop said Retrying... on the last attempt right before raising, and did not say what failed. now the last attempt raises directly and the warning includes the exception type and message

tested with unit tests for the parsed and fallback paths, a fake client for the retry loop, and the repo pre-commit hooks on the changed files

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@netlify

netlify Bot commented Sep 6, 2026

Copy link
Copy Markdown

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 694aa7e
🔍 Latest deploy log https://app.netlify.com/projects/poetic-froyo-8baba7/deploys/6a9d9da50c117b000808f31e
😎 Deploy Preview https://deploy-preview-1409--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: dc096c98-beac-45cd-a27d-205deb8e3642

📥 Commits

Reviewing files that changed from the base of the PR and between e5e26b8 and 694aa7e.

📒 Files selected for processing (3)
  • qdrant_client/http/exceptions.py
  • qdrant_client/uploader/grpc_uploader.py
  • qdrant_client/uploader/rest_uploader.py

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

UnexpectedResponse now reports the status.error value from valid JSON error bodies and retains the raw-content fallback. REST and gRPC uploaders now re-raise the original exception on the final retry. Intermediate retry warnings include the exception type and message.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 694aa

Server error messages now expose structured Qdrant error text when available, while upload retries retain the original final exception and provide clearer intermediate warnings. The fallback and retry behaviors remain bounded and ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes both primary changes: improved server error text and corrected upload retry warnings.
Description check ✅ Passed The description directly explains the error-reporting and retry-behavior changes, fallback behavior, testing, and pre-commit checks.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant