fix: show server error text, fix upload retry warning - #1409
Conversation
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthrough
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Server error messages now expose structured Qdrant error text when available, while upload retries retain the original final exception and provide clearer intermediate warnings. The fallback and retry behaviors remain bounded and ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
summary
fix: show server error text in UnexpectedResponse and fix upload retry warning
UnexpectedResponse.__str__now prints thestatus.errortext from the qdrant json body instead of raw bytes cut at 200 chars. falls back to the old raw output if the body is not json..contentand.structured()unchangedrest_uploader.pyandgrpc_uploader.pythe retry loop saidRetrying...on the last attempt right before raising, and did not say what failed. now the last attempt raises directly and the warning includes the exception type and messagetested with unit tests for the parsed and fallback paths, a fake client for the retry loop, and the repo pre-commit hooks on the changed files
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
pre-commitwithpip3 install pre-commitand set up hooks withpre-commit install?Changes to Core Features: