Skip to content

feat: Added transport test for test-plans#27

Merged
turuslan merged 33 commits into
qdrvm:mainfrom
bismuth01:test-plans
Feb 17, 2026
Merged

feat: Added transport test for test-plans#27
turuslan merged 33 commits into
qdrvm:mainfrom
bismuth01:test-plans

Conversation

@bismuth01
Copy link
Copy Markdown
Contributor

@bismuth01 bismuth01 commented Feb 9, 2026

Wrote a ping script that utilises the current available quic-v1 transport protocol with the current test-plans standard.

Tested on machine, through manual docker containers and also after integration in test-plans.
Please wait till I do a final run, there seems to be some yaml parsing issue

@bismuth01
Copy link
Copy Markdown
Contributor Author

Yes, now it's successfully working, can be merged.

Copy link
Copy Markdown
Contributor

@turuslan turuslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for integrating leanp2p and test-plans

Comment thread example/00-vcpkg-install/vcpkg-overlay/leanp2p/portfile.cmake Outdated
Comment thread test-plans/ping/CMakeLists.txt Outdated
Comment thread test-plans/CMakeLists.txt Outdated
@@ -0,0 +1 @@
add_subdirectory(ping) No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add newline at the end of file (github shows them with this red sign, git gui mark them too)

Comment thread CMakeLists.txt Outdated
Comment thread vcpkg.json Outdated
&& rm -rf $VCPKG_ROOT/.git

WORKDIR /build
COPY . .
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does source . expand to project root ".../leanp2p", or test-plans ".../leanp2p/test-plans/ping"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is project root. Need to copy the whole library and then build from root.
I tried creating a minimal project setup of leanp2p in test-plans, that might have been better as it wouldn't have added anymore dependencies like redis or extra code but the I made the decision due to build time.

Vcpkg takes approx 17 to 19 minutes to install and build dependencies when the library is copied inside the docker image. But when leanp2p is also added inside vcpkg, the time shoots to 25+ minutes as it also pulls in leanp2p and builds it.

Comment thread test-plans/ping/ping.cpp Outdated
Comment thread test-plans/ping/ping.cpp Outdated
turuslan and others added 5 commits February 13, 2026 17:09
- move reusable code to test-plans/common.hpp
- unique_ptr for redis pointers
- redis connect and commands helper functions
- TRY_OR_SL_FATAL to simplify test code
- TestTimeout accounts for elapsed time
@bismuth01
Copy link
Copy Markdown
Contributor Author

I have updated the repo as per your requirements, kindly check if anything else is needed.

@turuslan turuslan enabled auto-merge (squash) February 17, 2026 16:43
@turuslan turuslan merged commit 344c66e into qdrvm:main Feb 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants