feat: Added transport test for test-plans#27
Conversation
2e98584 to
fe93b67
Compare
fe93b67 to
0b4af85
Compare
|
Yes, now it's successfully working, can be merged. |
turuslan
left a comment
There was a problem hiding this comment.
Thank you for integrating leanp2p and test-plans
| @@ -0,0 +1 @@ | |||
| add_subdirectory(ping) No newline at end of file | |||
There was a problem hiding this comment.
Please add newline at the end of file (github shows them with this red sign, git gui mark them too)
| && rm -rf $VCPKG_ROOT/.git | ||
|
|
||
| WORKDIR /build | ||
| COPY . . |
There was a problem hiding this comment.
Does source . expand to project root ".../leanp2p", or test-plans ".../leanp2p/test-plans/ping"?
There was a problem hiding this comment.
It is project root. Need to copy the whole library and then build from root.
I tried creating a minimal project setup of leanp2p in test-plans, that might have been better as it wouldn't have added anymore dependencies like redis or extra code but the I made the decision due to build time.
Vcpkg takes approx 17 to 19 minutes to install and build dependencies when the library is copied inside the docker image. But when leanp2p is also added inside vcpkg, the time shoots to 25+ minutes as it also pulls in leanp2p and builds it.
|
I have updated the repo as per your requirements, kindly check if anything else is needed. |
Wrote a ping script that utilises the current available quic-v1 transport protocol with the current test-plans standard.
Tested on machine, through manual docker containers and also after integration in test-plans.
Please wait till I do a final run, there seems to be some yaml parsing issue