Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a containerized build-and-package pipeline for the VirtIO GPU Windows driver artifacts, with a GitHub Actions workflow that builds, validates, zips, and publishes the resulting package.
Changes:
- Add a multi-stage
Dockerfilethat assembles a pinned toolchain (Rust, MinGW, EWDK subset), builds dependencies (Mesa, virtio-d3d11, makecat), and produces a final packaged artifact. - Add a
BuildGitHub Actions workflow to resolve floating upstream SHAs, run the Docker BuildKit build, validate outputs, create a ZIP, and publish a GitHub Release. - Add a
.dockerignorethat restricts the Docker build context to only theDockerfile.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Dockerfile | Defines the end-to-end reproducible toolchain, build, ABI checks, packaging, and artifact export. |
| .github/workflows/build.yml | Implements the CI workflow to build, validate, archive, and release the driver package. |
| .dockerignore | Minimizes Docker build context to improve reproducibility and reduce build context size. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| uses: action-pack/send-mail@33d560748d5c56be2a180c578ba4cf92b22a4723 | ||
| with: | ||
| to: ${{ secrets.MAILTO }} | ||
| from: Github Actions <${{ secrets.MAILTO }}> |
Comment on lines
+395
to
+399
| -sha256 \ | ||
| -days 3650 \ | ||
| -config /opt/test-cert/openssl.cnf \ | ||
| -keyout /opt/test-cert/key.pem \ | ||
| -out /opt/test-cert/cert.pem \ |
| MSVC tools: ${VCTOOLSVER} | ||
| Rust: ${RUST_TOOLCHAIN} | ||
| cbindgen: ${CBINDGEN_VERSION} | ||
| Ubuntu base manifest: sha256:1e0a86e57d247923571b75e0aaf48a1449cf8c543d51fb3e07a4a7d7bfa79316 |
Comment on lines
+291
to
+302
| ARG VERSION_ARG | ||
| ARG KMD_SHA | ||
| ARG D3D11_SHA | ||
| ARG DXVK_SHA | ||
| ARG MESA_TREE_SHA256 | ||
| ARG MAKECAT_REF | ||
| ARG CLANG_CL_LINUX_REF | ||
| ARG EWDK_VERSION | ||
| ARG VCTOOLSVER | ||
| ARG WINSDKVER | ||
| ARG RUST_TOOLCHAIN | ||
| ARG CBINDGEN_VERSION |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.