-
Notifications
You must be signed in to change notification settings - Fork 769
PPC debugger XML support #1600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPC debugger XML support #1600
Conversation
|
Thanks for contributing to the project. |
|
Ah sorry didn't see that I use it to hash bb_entry , with that i can filter most of duplicate entry. If not wanted or problematic, i can remove it from PR. Or maybe we have a simpler alternative that's doesn't override c_types.Structure init? |
|
yea thought about it and i should use: We still use original c_type.Structure constructor + we can use hashable bbEntry |
|
Thanks for the clarification. Though I am not sure I understand why this has to be part of the project.. As far as I understand, this can be part of your own private script that de-duplicates covered basic blocks. In case you would like to incorporate the de-duplication code into the project as well, then it will make more sense to include this change. BTW - even in this case the Please let me know if I misunderstood this. |
|
ye i understand. Do you want me to remove it ? |
|
If this addition (that is, the methods that helps turning it into hashable) is there only to serve your own scripts, then it shouldn't be there. In other words, either we introduce a feature that uses it and all Qiling users can benefit from, or we drop the changes. |
|
Thanks! |
Hi
I added basic xml support for PPC arch for gdb debugger
Also i update a little drcov coverage : added some constructor functions in the drcov class, that allow python set() to work (I have some cases where i have a lot of drcov trace for the same binary, this help a lot to filter and set unique bbs)
(sorry for duplicates got issues with git)
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing