Skip to content

release #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qinscode merged 1 commit into from
May 21, 2025
Merged

release #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/github/analysis/components/StudentOrderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ const StudentOrderer: React.FC<StudentOrdererProps> = ({ onReorder }) => {
fontSize: "1.25rem",
color: "#3B82F6",
letterSpacing: "0.01em",
cursor: "default",
}}
>
Student Order{" "}
Expand Down
3 changes: 3 additions & 0 deletions src/components/github/analysis/components/layout/AnalysisHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const AnalysisHeader = ({
enterDelay={500}
leaveDelay={200}
placement="top"
sx={{ cursor: "default" }}
title={`${title}${description ? ` - ${description}` : ""}${headerTitle ? ` (${headerTitle})` : ""}`}
>
<Box
Expand Down Expand Up @@ -62,6 +63,7 @@ const AnalysisHeader = ({
mb: description ? 1 : 0,
position: "relative",
zIndex: 1,
cursor: "default",
}}
>
{title}
Expand All @@ -74,6 +76,7 @@ const AnalysisHeader = ({
color: "rgba(107, 114, 128, 0.9)",
position: "relative",
zIndex: 1,
cursor: "default",
}}
>
{description}
Expand Down
44 changes: 37 additions & 7 deletions src/components/github/analysis/components/teamwork/TeamworkTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,22 @@
import { Box, Typography, TableContainer, Table, TableHead, TableRow, TableCell, TableBody, Avatar, Chip, Card, Grow, alpha } from "@mui/material";
import { ChatBubble as CommentIcon, RateReview as ReviewIcon } from "@mui/icons-material";
import {
Box,
Typography,
TableContainer,
Table,
TableHead,
TableRow,
TableCell,
TableBody,
Avatar,
Chip,
Card,
Grow,
alpha,
} from "@mui/material";
import {
ChatBubble as CommentIcon,
RateReview as ReviewIcon,
} from "@mui/icons-material";
import { TeamworkColors } from "./TeamworkTheme";

interface TeamworkTableProps {
Expand All @@ -19,7 +36,9 @@ const TeamworkTable: React.FC<TeamworkTableProps> = ({
index,
}) => {
const isIssuesTable = title.includes("Issues");
const lightColor = isIssuesTable ? TeamworkColors.light : "rgba(139, 92, 246, 0.1)";
const lightColor = isIssuesTable
? TeamworkColors.light
: "rgba(139, 92, 246, 0.1)";
const lighterColor = isIssuesTable
? TeamworkColors.lighter
: "rgba(139, 92, 246, 0.05)";
Expand Down Expand Up @@ -72,18 +91,29 @@ const TeamworkTable: React.FC<TeamworkTableProps> = ({
>
{isIssuesTable ? (
<CommentIcon
sx={{ fontSize: "1.2rem", color: TeamworkColors.primaryText, marginRight: 1.5 }}
sx={{
fontSize: "1.2rem",
color: TeamworkColors.primaryText,
marginRight: 1.5,
}}
/>
) : (
<ReviewIcon
sx={{ fontSize: "1.2rem", color: TeamworkColors.secondaryText, marginRight: 1.5 }}
sx={{
fontSize: "1.2rem",
color: TeamworkColors.secondaryText,
marginRight: 1.5,
}}
/>
)}
<Typography
sx={{
fontSize: "1rem",
fontWeight: 600,
color: isIssuesTable ? TeamworkColors.primaryText : TeamworkColors.secondaryText,
color: isIssuesTable
? TeamworkColors.primaryText
: TeamworkColors.secondaryText,
cursor: "default",
}}
>
{title}
Expand Down Expand Up @@ -221,4 +251,4 @@ const TeamworkTable: React.FC<TeamworkTableProps> = ({
);
};

export default TeamworkTable;
export default TeamworkTable;
12 changes: 10 additions & 2 deletions src/components/github/analysis/tabs/CommitsTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,12 @@ function UserCommits({
sx={{ color: commitsTheme.main, mr: 1, fontSize: "1.1rem" }}
/>
<Typography
sx={{ color: "rgba(55, 65, 81, 0.9)", fontWeight: 600 }}
variant="subtitle2"
sx={{
color: "rgba(55, 65, 81, 0.9)",
fontWeight: 600,
cursor: "default",
}}
Comment on lines +82 to +86

Copilot AI May 21, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using theme.palette.text.secondary with an alpha modifier instead of hardcoding an RGBA color to maintain theming consistency.

Suggested change
sx={{
color: "rgba(55, 65, 81, 0.9)",
fontWeight: 600,
cursor: "default",
}}
sx={(theme) => ({
color: alpha(theme.palette.text.secondary, 0.9),
fontWeight: 600,
cursor: "default",
})}

Copilot uses AI. Check for mistakes.
>
Weekly Commit Frequency
</Typography>
Expand Down Expand Up @@ -182,8 +186,12 @@ function CommitsTab({ data }: CommitsTabProps) {
sx={{ color: commitsTheme.main, mr: 1, fontSize: "1.2rem" }}
/>
<Typography
sx={{ color: "rgba(55, 65, 81, 0.9)", fontWeight: 600 }}
variant="h6"
sx={{
color: "rgba(55, 65, 81, 0.9)",
fontWeight: 600,
cursor: "default",
}}
>
Contributor Commit Timeline
</Typography>
Expand Down
10 changes: 6 additions & 4 deletions src/components/github/analysis/tabs/TeamworkTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import { useMemo, useContext } from "react";
import { Box, Typography, Fade, alpha, useTheme } from "@mui/material";
import { RepoData } from "@/services/github";
import { RepoContext } from "@/components/github/repo-analysis/RepoResults";
import {
TeamworkTable,
TeamworkInteractionsTable
import {
TeamworkTable,
TeamworkInteractionsTable,
} from "../components/teamwork";

interface TeamworkTabProps {
Expand Down Expand Up @@ -97,6 +97,7 @@ function TeamworkTab({ data }: TeamworkTabProps) {
color: alpha(theme.palette.primary.main, 0.7),
mb: 2,
fontWeight: 500,
cursor: "default",

Copilot AI May 21, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Repeated use of cursor: "default" across multiple components could be centralized. Consider defining a reusable style or theme override for non-interactive text elements to reduce duplication.

Suggested change
cursor: "default",
...nonInteractiveTextStyle,

Copilot uses AI. Check for mistakes.
}}
>
No teamwork data available for this repository
Expand All @@ -107,6 +108,7 @@ function TeamworkTab({ data }: TeamworkTabProps) {
color: alpha(theme.palette.text.secondary, 0.7),
maxWidth: "600px",
mx: "auto",
cursor: "default",
}}
>
This repository doesn't have any recorded issue comments or pull
Expand Down Expand Up @@ -169,4 +171,4 @@ function TeamworkTab({ data }: TeamworkTabProps) {
);
}

export default TeamworkTab;
export default TeamworkTab;