This repository was archived by the owner on Dec 8, 2024. It is now read-only.
Add configuration for build time dependencies#146
Open
EdmundGoodman wants to merge 1 commit intoqmlcode:developfrom
Open
Add configuration for build time dependencies#146EdmundGoodman wants to merge 1 commit intoqmlcode:developfrom
EdmundGoodman wants to merge 1 commit intoqmlcode:developfrom
Conversation
Author
|
It is also worth noting as shown in the warning message in #143 that
|
Member
|
Please note that further development for the QML package is now happening on the qmlcode/qmllib repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #145.
In accordance with https://peps.python.org/pep-0517/ , the build time dependency NumPy should be specified, as otherwise QML cannot be installed unless NumPy is already installed on the system, which breaks installation in fresh virtual environments.
This change specifies the build time dependency, and so should fix the issue. Once it is released, the following commands should run without error:
python3 -m venv venv source venv/bin/activate pip install qml