feat(scenario): give the cases places to investigate and routes to the death estimate - #17
Merged
Merged
Conversation
Backfill 22 reviewed scenarios with place-based findings alongside character routes, mark death-time evidences with dual disclosure paths, and add migrations 0021/0022 plus authoring and public-layer test coverage for the new invariants. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scenario data for the two features #15 and #16 shipped the machinery for. Until now only
the two demo cases carried any, so almost every case ran with the new board and nothing
to put on it.
What changes
estimatedDeathAtpresentrevealsDeathTimeplaces21 scenario files in all.
The nine were the ones worth fixing. Each had a death estimate written and no evidence
marked to disclose it, so the board would have kept its dotted window and its question
mark to the end of the case — a search with no finish. The authoring guide names this as
the worst of the three failures precisely because neither half is wrong on its own, so
validation cannot catch it.
Migrations
0021_scenario-investigation-upgrade.sql— the new place and disclosure data fordatabases already seeded.
0022_scenario-place-public-copy-safety.sql— rewrites the public half of the placeentries (
introduction,situation) to be spoiler-neutral. Privatefindingsareuntouched. Same rule as everywhere else in the case data: what the roster and the
nameplate show is public and keyword-checked, what you learn by examining is earned.
Test plan
bun run typecheck— cleanbun run lint— no errorsbun run test— 721 pass / 0 failbun run db:seed— all 43 scenarios compile, and regenerating leavesseed.sqlunchanged, so the committed seed matches the YAML
0021and0022both rewrite rows on an existing database — worth alook at whether the public copy in
0022reads as neutral to someone who has notplayed the case