chore: back-merge the history hotfix into develop - #22
Open
tkgstrator wants to merge 3 commits into
Open
Conversation
The board stops asserting a death estimate the player has not earned, places become a third kind of subject beside people and the body, and the interrogation takes topics rather than literal questions. Plus a month of previously unpushed work and every screen matched against its mock.
Opening a case with investigable places threw "the response is not the shape we expected" before the player could ask anything. The interrogation screen reads the history the moment it mounts, and the history's characterId only allowed a uuid or the literal victim — places carry an author-written local id, so every case holding one failed to parse and took the screen down with it. That is 17 of the 43 cases now in production. The comment above that union already warned about exactly this, having been written when the body was added as a second kind of subject. Adding a third did not reach it. Found on 十七回忌の客: two sessions, no messages, no model calls — it never got past the first read. Co-Authored-By: Claude <noreply@anthropic.com>
The interrogation screen reads the history as it mounts, and the characterId union allowed only a uuid or the literal victim. Places carry an author-written local id, so all 17 cases holding one failed to parse and took the screen down before the player could ask anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings #21 back so the next release does not undo it.
The hotfix branched off
masterbecausedevelopwas holding unreviewed work at the time.Without this,
develop → masterwould ship a tree where the fix has been reverted.Fast-forward:
masteralready contained everything ondevelop(the v0.4.0 release merge),so this is the hotfix commit and the release merge, nothing else.
Test plan
bun run typecheck— cleanbun run test— 725 pass / 0 fail