Skip to content

Now it works!#11

Open
avivalund wants to merge 19 commits into
qtran4:mainfrom
avivalund:main
Open

Now it works!#11
avivalund wants to merge 19 commits into
qtran4:mainfrom
avivalund:main

Conversation

@avivalund
Copy link
Copy Markdown

No description provided.


}
}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

stop("Invalid value for naOption parameter")
}
write.csv(input, paste("country",country,"_alldata.csv"), row.names = F)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

}
write.csv(input, paste("country",country,"_alldata.csv"), row.names = F)

}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary function?

Comment thread analysis_for_grading.R
#Path directory
setwd("/Users/avivalund/Desktop/Biocomputing/FinalProject/RProject/")

#Compile; couldnt get source to work so here is the code that would compile the csvs
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use source only if the file is exist in the same directory

Comment thread analysis_for_grading.R

#number of infected or healthy patients; removed ages that were likely errors
removed_strange_ages<-data[data$age <110,]
sick<-subset(removed_strange_ages, marker01!=0 | marker02!=0 |marker03!=0 |marker04!=0 |marker05!=0 |marker06!=0 |marker07!=0 |marker08!=0 | marker09!=0 |marker10!=0)
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use for loop on this

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-0.25 for code inefficiency

Comment thread analysis_for_grading.R
theme_bw()+
scale_y_continuous(breaks =seq(0,15000,1250))
}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

Comment thread analysis_for_grading.R
geom_bar(stat="identity", position="dodge")+
xlab("Country") +
ylab("Marker Abundance")+
theme_minimal() No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did not use any support functions in the script -2

Comment thread analysis_for_grading.R
geom_bar(stat="identity", position="dodge")+
xlab("Country") +
ylab("Marker Abundance")+
theme_minimal() No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good commenting and efficient code that uses coding concepts that we covered in class – 3.75 points (max is 4)

Copy link
Copy Markdown
Owner

@qtran4 qtran4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13.75

Comment thread analysis_for_grading.R
@@ -0,0 +1,157 @@
#github was very uncooperative, we all did pretty equal work though
#1)our figures provide good evidence based on the cases per day the the disease originated in country X.
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not specific enough. You need to point to the evidence from the graph and say why the cases matter.
-0.5

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it's unclear which graph you are referring to

Comment thread analysis_for_grading.R
#github was very uncooperative, we all did pretty equal work though
#1)our figures provide good evidence based on the cases per day the the disease originated in country X.
#2)We also determined that a vaccine developed in country Y would have limited uses for country X.
#The disparity in markers present between the two countries means that the little overlap that doesoccur would not confer good immunity to country X people.
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which graph you are referring to?
It is not clear how disparity it is. You need to point out the evidence from the graph
-0.5

Copy link
Copy Markdown
Owner

@qtran4 qtran4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16.75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants