Remove deprecated channel-level port properties - #195
Open
nulinspiratie wants to merge 1 commit into
Open
Conversation
Remove the following deprecated fields and the associated deprecation warning logic: - SingleChannel: opx_output_offset, filter_fir_taps, filter_iir_taps - InSingleChannel: opx_input_offset - IQChannel: opx_output_offset_I, opx_output_offset_Q, rf_frequency property - InIQChannel: opx_input_offset_I, opx_input_offset_Q - DigitalOutputChannel: shareable, inverted Also removes the _create_port_property_deprecation_message helper. These properties have been on Port objects since v0.5.0. Update tests, documentation, and changelog accordingly.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opx_output_offset,filter_fir_taps,filter_iir_taps,opx_input_offset,opx_output_offset_I/Q,opx_input_offset_I/Q,DigitalOutputChannel.shareable/inverted, andIQChannel.rf_frequency_create_port_property_deprecation_messagehelper function (no longer needed)What changed
quam/components/channels.py: Removed deprecated fields and all associated deprecation warning logic fromDigitalOutputChannel,SingleChannel,InSingleChannel,IQChannel, andInIQChannel. Port constructors inapply_to_confignow use defaults only.Tests: Updated attribute annotation tests and removed test cases that exercised the removed properties. Replaced
rf_frequencywithRF_frequencyin transmon tests.Docs: Removed deprecated-property warning callouts and the full migration guide from
channels.md. Updatedchannel-ports.mdbest practices. Cleaned updemonstration.mdrepr examples.Test plan
python -m pytest tests/ -q)AttributeErrornow if used)