Fix mypy type error in MWFEMAnalogInputPort.get_port_properties - #224
Merged
Conversation
port_properties was an untyped dict literal, so mypy inferred its value type from the initial int/float/bool entries (joined to float), then rejected the later lo_mode Literal["auto", "always_on"] assignment. Annotate it as Dict[str, Any] to match the function's declared return type. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BSjkz5MSzwofzPG8vKfcA2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quam/components/ports/analog_inputs.pythat fails thelintjob'smypystep on every PR (e.g. run 30467312812).lo_mode), but only started failing CI once Feature/mypy and formatting #217 added the mypy check to the lint job.port_propertieswas an untyped dict literal, so mypy inferred its value type from the initial int/float/bool entries (joining tofloat), then rejected the laterlo_mode: Literal["auto", "always_on"]assignment. Annotating it asDict[str, Any](matching the function's own declared return type) fixes it — no behavior change.Test plan
mypy quam/ --ignore-missing-imports --follow-imports=silent— 0 errors (was 1)black --check quam/— unchanged, passespflake8 quam/— passes🤖 Generated with Claude Code
https://claude.ai/code/session_01BSjkz5MSzwofzPG8vKfcA2