Skip to content

QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1 - #1007

Closed
mvadlama-lab wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mvadlama-lab:cam1imx-indent
Closed

mvadlama-lab wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mvadlama-lab:cam1imx-indent

Conversation

@mvadlama-lab

Copy link
Copy Markdown

CAM1 port is currently enabled for OV9282.This change adds DTSI configuration for IMX577 so that CAM1 can also support IMX577 sensor on the hardware platform of QCM6490 Dev.

CRs-Fixed: 4633982

CAM1 port is currently enabled for Ov9282. This change adds
DTSI configuration for IMX577 so that CAM1 can also support
IMX577 sensor on the hardware platform of QCM6490 Dev.

Signed-off-by: Vadlamani Manjusha <mvadlama@qti.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #1007 — validate-patch

PR: #1007

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1007 - QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Upstream commit: N/A (vendor-only commit)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear explanation of CAM1 IMX577 support
Fixes tag present/correct N/A New feature, no fix
Authorship preserved Signed-off-by present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi Adds eeprom_cam1 and qcom,cam-sensor12 nodes for IMX577 sensor support

Issues

None — vendor-only commit with clear purpose and correct device tree syntax.

Verdict

Merge as-is. This is a vendor-only device tree addition for IMX577 camera sensor support on QCM6490 RB3Gen2. The commit is properly formatted, the changes are syntactically correct, and the commit is already present in the kernel topic branches.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Yes — commit is present in topics (integration_presence_report.md confirms all added lines are present)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

Copy link
Copy Markdown

PR #1007 — checker-log-analyzer

PR: #1007
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32834305398

Checker Result Summary
Checker Result Summary
checkpatch 2 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Multiple schema validation failures for camera nodes
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance QCLINUX: prefix not in allowed list
tag-check N/A (qcom-6.18.y branch exempt from prefix requirement)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1007 - QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32834305398
Target Branch: qcom-6.18.y

Checker Result Summary
checkpatch 2 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Multiple schema validation failures for camera nodes
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance QCLINUX: prefix not in allowed list
tag-check N/A (qcom-6.18.y branch exempt from prefix requirement)

❌ checkpatch

Root cause: Two vendor-specific DT compatible strings are not documented in vendor-prefixes.yaml.

Failure details:

WARNING: DT compatible string "qcom,eeprom" appears un-documented -- check ./Documentation/devicetree/bindings/
#26: FILE: arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi:180:
+		compatible = "qcom,eeprom";

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#64: FILE: arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi:218:
+		compatible = "qcom,cam-sensor";

Fix: These are vendor-specific camera subsystem compatible strings. Two options:

  1. Add DT binding documentation (recommended for upstream):

    • Create Documentation/devicetree/bindings/media/qcom,eeprom.yaml
    • Create Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml
  2. Accept as vendor-only (if not upstreaming):

    • These warnings are acceptable for vendor-only DTS changes
    • The compatible strings are already used elsewhere in the tree

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git dc0f4d4280a7..9c84a020ce63

❌ dtb-check

Root cause: The new camera sensor nodes fail schema validation because qcom,eeprom and qcom,cam-sensor compatible strings have no upstream bindings, and the nodes are missing the required ranges property expected by the parent qcom,cci binding.

Failure details:

qcom,cci0 (qcom,cci): qcom,cam-sensor12: 'ranges' is a required property
qcom,cci0 (qcom,cci): qcom,eeprom1: 'ranges' is a required property
/soc@0/qcom,cci0/qcom,cam-sensor12: failed to match any schema with compatible: ['qcom,cam-sensor']
/soc@0/qcom,cci0/qcom,eeprom1: failed to match any schema with compatible: ['qcom,eeprom']
qcom,cam-sensor12 (qcom,cam-sensor): gpio-req-tbl-label: b'CAMIF_MCLK1^@CAM_RESET1^@CAM_CUSTOM1^@' is not of type 'object', 'integer', 'array', 'boolean', 'null'
qcom,eeprom1 (qcom,eeprom): gpio-req-tbl-label: b'CAMIF_MCLK1^@CAM_RESET1^@CAM_CUSTOM1^@' is not of type 'object', 'integer', 'array', 'boolean', 'null'

Analysis:

  1. Missing schema: No binding YAML exists for qcom,eeprom or qcom,cam-sensor — these are vendor-specific camera subsystem nodes
  2. Missing ranges property: The parent qcom,cci binding expects child nodes to have a ranges property
  3. Property type mismatch: gpio-req-tbl-label is a vendor-specific string array property not recognized by standard schemas

Fix:

These are vendor-specific camera subsystem nodes that do not have upstream bindings. The dtb-check failures are expected for vendor-only DTS additions. Two paths forward:

  1. If upstreaming is planned:

    • Add proper DT binding YAML files for qcom,eeprom and qcom,cam-sensor
    • Add ranges; property to both nodes (empty ranges for non-translating bridges)
    • Document all vendor-specific properties (gpio-req-tbl-label, pwm-switch, etc.)
  2. If vendor-only (current state):

    • These failures are acceptable — the nodes follow existing patterns in the tree
    • The same compatible strings and properties are used in other camera sensor nodes
    • The hardware will function correctly despite schema validation failures

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs5430-fps-camx.dtb
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine-camx.dtb

❌ check-patch-compliance

Root cause: The commit uses the QCLINUX: prefix, which is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Commit summary does not start with a required prefix

Analysis:

This is a known checker limitation for vendor-only commits. The check-patch-compliance checker only accepts upstream-linkable prefixes:

  • FROMLIST: — posted to mailing list
  • FROMGIT: — in a maintainer tree
  • UPSTREAM: — merged into mainline
  • BACKPORT: — backported with modifications

The QCLINUX: prefix is used for vendor-only changes with no upstream equivalent, but the checker does not recognize it.

Fix:

No action required. This is a vendor-only DTS change for Qualcomm camera subsystem support. The QCLINUX: prefix is correct and intentional. The checker failure is expected and acceptable for vendor-only commits.

If this were to be upstreamed in the future:

  1. Post the patch to the devicetree mailing list
  2. Change prefix to FROMLIST:
  3. Add Link: <lore-url> to the commit message

Verdict

3 blockers to address before merge:

  1. checkpatch warnings — Acceptable as vendor-only; or add DT bindings if upstreaming
  2. dtb-check failures — Expected for vendor-specific camera nodes without upstream bindings; acceptable as-is
  3. check-patch-compliance failure — Known limitation; QCLINUX: prefix is correct for vendor-only changes

Recommendation: The failures are all related to vendor-specific camera subsystem nodes that lack upstream DT bindings. If this is a vendor-only change (not intended for upstream), all failures are acceptable and the PR can merge as-is. If upstreaming is planned, DT binding YAML files must be added first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants