Skip to content

Enable audio support on talos-lyra-evk - #1051

Merged
Salendarsingh Gaud (sgaud-quic) merged 2 commits into
qualcomm-linux:qcom-6.18.yfrom
ks5-dev:topic/lyra_audio_support
Sep 11, 2026
Merged

Salendarsingh Gaud (sgaud-quic) merged 2 commits into
qualcomm-linux:qcom-6.18.yfrom
ks5-dev:topic/lyra_audio_support

Conversation

@ks5-dev

@ks5-dev ks5-dev commented Sep 7, 2026

Copy link
Copy Markdown

This series includes:
pinctrl: qcom: add QCS615 LPASS LPI pinctrl driver
Add the LPASS LPI pinctrl driver for the QCS615 SoC. The driver
supports 32 GPIOs in the range 0-31 and provides pin control
functionality for the LPASS LPI block.

ASoC: qcom: sc8280xp: enable support for talos-lyra
Add the necessary board widgets, kcontrols and DAPM routes
for max98091 codec support. Enable required DAI format, sysclk
and other required configs.

Link: https://jira-dc.qualcomm.com/jira/browse/QLIJIRA-172
CRs-Fixed: 4670734

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@ks5-dev
ks5-dev force-pushed the topic/lyra_audio_support branch from 8a82437 to 1e5cb90 Compare September 8, 2026 13:00
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@ks5-dev

ks5-dev commented Sep 9, 2026

Copy link
Copy Markdown
Author

qli-2.1 pull-request freeze

@ks5-dev

ks5-dev commented Sep 9, 2026

Copy link
Copy Markdown
Author

@ks5-dev

ks5-dev commented Sep 9, 2026

Copy link
Copy Markdown
Author

Add the necessary board widgets, kcontrols and DAPM routes
for max98091 codec support. Enable required DAI format, sysclk
and other required configs.

Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
@ks5-dev
ks5-dev force-pushed the topic/lyra_audio_support branch from 1e5cb90 to bcafb78 Compare September 9, 2026 10:15
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia purwa-iot-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ⚠️ skip ◻️ ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip
BT_FW_KMD_Service ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPUFreq_Validation ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ⚠️ skip ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet_Basic_Validation ⚠️ skip ◻️ ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ❌ Fail ❌ Fail ⚠️ skip
Freq_Scaling ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail
IPA ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
KVM_Driver ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_EL2_DTB ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_Infra ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
OpenCV ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Probe_Failure_Check ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
USBHost ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail
WiFi_Firmware_Driver ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
adsp_remoteproc ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
cdsp_remoteproc ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ◻️ ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip
hotplug ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ✅ Pass ✅ Pass ❌ Fail ✅ Pass
watchdog ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass

@@ -0,0 +1,185 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct year?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

// SPDX-License-Identifier: GPL-2.0-only
/*
* Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
* ALSA SoC platform-machine driver for QTi LPASS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix description? this should be LPASS LPI pinctrl driver ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Add the LPASS LPI pinctrl driver for the QCS615 SoC. The driver
supports 32 GPIOs in the range 0-31 and provides pin control
functionality for the LPASS LPI block.

Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
@ks5-dev
ks5-dev force-pushed the topic/lyra_audio_support branch from bcafb78 to 1d72af4 Compare September 10, 2026 13:39
@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case *

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia purwa-iot-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet_Basic_Validation ⚠️ skip ✅ Pass ◻️ ⚠️ skip ⚠️ skip ⚠️ skip ◻️ ❌ Fail ⚠️ skip
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
KVM_Driver ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_EL2_DTB ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_Infra ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
USBHost ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail
WiFi_Firmware_Driver ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ✅ Pass ✅ Pass ❌ Fail ✅ Pass
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass

@sgaud-quic
Salendarsingh Gaud (sgaud-quic) merged commit 7d1360b into qualcomm-linux:qcom-6.18.y Sep 11, 2026
6 of 8 checks passed
@qlijarvis

Copy link
Copy Markdown

PR #1051 — validate-patch

PR: #1051

Verdict Issues Detailed Report
⚠️ 3 Full report

Final Summary

Commit 1/2:

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Partial - 2/2 commit(s) only have partial integration evidence

Commit 2/2:

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Partial - 2/2 commit(s) only have partial integration evidence
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1051 - PENDING: ASoC: qcom: sc8280xp: enable support for talos-lyra + PENDING: pinctrl: qcom: add QCS615 LPASS LPI pinctrl driver
Upstream commit: N/A (PENDING: prefix - work-in-progress, not posted upstream)
Verdict: ⚠️ PARTIAL

Commit 1/2: PENDING: ASoC: qcom: sc8280xp: enable support for talos-lyra

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix - no upstream source to compare
Body preserves rationale Clear description of board widgets, kcontrols, and DAPM routes for max98091 codec
Fixes tag present/correct N/A New feature, no Fixes tag required
Authorship preserved Karthik S karthik.s@oss.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
Documentation/devicetree/bindings/sound/qcom,sm8250.yaml Adds qcom,talos-lyra-sndcard compatible
sound/soc/qcom/Kconfig Adds SND_SOC_MAX98090 dependency
sound/soc/qcom/sc8280xp.c Adds talos_lyra DAPM widgets, routes, controls, and priv_data

Commit 2/2: PENDING: pinctrl: qcom: add QCS615 LPASS LPI pinctrl driver

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix - no upstream source to compare
Body preserves rationale Clear description of driver purpose and GPIO range
Fixes tag present/correct N/A New driver, no Fixes tag required
Authorship preserved Karthik S karthik.s@oss.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
Documentation/devicetree/bindings/pinctrl/qcom,qcs615-lpass-lpi-pinctrl.yaml New DT binding for QCS615 LPASS LPI pinctrl
arch/arm64/configs/defconfig Enables new driver in defconfig
drivers/pinctrl/qcom/Kconfig Adds config option for QCS615 LPI pinctrl
drivers/pinctrl/qcom/Makefile Adds build rule for new driver
drivers/pinctrl/qcom/pinctrl-qcs615-lpass-lpi.c New driver implementation with 32 GPIOs, functions, and groups

Issues

Commit 1/2:

  • ⚠️ Commit message mentions "max98091 codec" but Kconfig selects SND_SOC_MAX98090 (note: 98090 vs 98091 discrepancy)
  • ⚠️ Integration presence shows "partial" - subject or partial tree evidence found, but full change not verified in qcom-next/topics

Commit 2/2:

  • ⚠️ Integration presence shows "partial" - subject or partial tree evidence found, but full change not verified in qcom-next/topics

Verdict

PENDING: prefix commits are work-in-progress and not yet posted upstream. These commits cannot be validated against lore.kernel.org sources per the validate-patch skill scope. The commit messages are clear and well-structured for vendor-internal review. However, note the codec name discrepancy (max98091 vs max98090) in commit 1/2, and both commits show only partial integration evidence in qcom-next/topics.

Final Summary

Commit 1/2:

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Partial - subject or partial tree evidence found, but full change was not verified (per integration_presence_report.md)

Commit 2/2:

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Partial - subject or partial tree evidence found, but full change was not verified (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] PENDING: ASoC: qcom: sc8280xp: enable support for partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
2/2 [PATCH 2/2] PENDING: pinctrl: qcom: add QCS615 LPASS LPI pinctrl partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: PARTIAL
present_commits: 0/2
partial_commits: 2/2
missing_commits: 0/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Partial - 2/2 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #1051 — checker-log-analyzer

PR: #1051
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34484153171

Checker Result Summary
Checker Result Summary
checkpatch 2 commits with DT_SPLIT_BINDING warnings
dt-binding-check All binding validations passed
dtb-check ⏭️ Skipped - no devicetree changes
sparse-check Passed (unrelated build errors in imagination driver)
check-uapi-headers Passed - no UAPI changes
check-patch-compliance 2 commits with invalid prefix PENDING:
tag-check 2 commits missing required subject prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1051 - ASoC and pinctrl updates for talos-lyra and QCS615
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/34484153171
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch 2 commits with DT_SPLIT_BINDING warnings
dt-binding-check All binding validations passed
dtb-check ⏭️ Skipped - no devicetree changes
sparse-check Passed (unrelated build errors in imagination driver)
check-uapi-headers Passed - no UAPI changes
check-patch-compliance 2 commits with invalid prefix PENDING:
tag-check 2 commits missing required subject prefix

❌ checkpatch

Root cause: Both commits include DT binding header changes that should be in separate patches per kernel submission guidelines.

Failure details:

Commit 6b84628cc339 ("PENDING: ASoC: qcom: sc8280xp: enable support for talos-lyra")
WARNING: DT binding docs and includes should be a separate patch.
6b84628cc339 total: 0 errors, 1 warnings, 0 checks, 78 lines checked

Commit 1d72af427d71 ("PENDING: pinctrl: qcom: add QCS615 LPASS LPI pinctrl driver")
WARNING: DT binding docs and includes should be a separate patch.
1d72af427d71 total: 0 errors, 1 warnings, 0 checks, 329 lines checked

Fix: Split each commit into two patches:

  1. First patch: DT binding documentation and include/dt-bindings header changes
  2. Second patch: Driver implementation changes

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 1ca2821f5ed01f3bd238a8da6f489c638109ce11..b9926e587f0d2f34087965540c5d8e99c7f110ae

❌ check-patch-compliance

Root cause: Both commits use the PENDING: prefix, which is not in the allowed list of upstream-linkable prefixes.

Failure details:

Checking commit: PENDING: ASoC: qcom: sc8280xp: enable support for talos-lyra
Commit summary does not start with a required prefix

Checking commit: PENDING: pinctrl: qcom: add QCS615 LPASS LPI pinctrl driver
Commit summary does not start with a required prefix

Fix: The check-patch-compliance checker only accepts these prefixes:

  • FROMLIST: - Patch posted to mailing list (lore.kernel.org)
  • FROMGIT: - Patch taken from a maintainer git tree
  • UPSTREAM: - Patch merged into Linus's mainline tree
  • BACKPORT: - Upstream patch backported with modifications

If these patches have been posted upstream, change the prefix to FROMLIST: and add a Link: tag pointing to the lore.kernel.org URL. If they are vendor-only work-in-progress, this checker will always fail — this is a known limitation for PENDING: and QCLINUX: prefixed commits.

Note: This is a known checker limitation. The PENDING: prefix is used in the tree for work-in-progress commits but is not accepted by the upstream compliance checker.


❌ tag-check

Root cause: The PR targets qcom-6.18.y (not qcom-next or qcom-next-staging), which requires all commits to have a valid subject prefix. Both commits use PENDING:, which is a valid prefix.

Analysis: Upon review, both commits do have the PENDING: prefix, which is one of the accepted prefixes for tag-check:

  • ✅ Commit 6b84628: PENDING: ASoC: qcom: sc8280xp: enable support for talos-lyra
  • ✅ Commit 1d72af4: PENDING: pinctrl: qcom: add QCS615 LPASS LPI pinctrl driver

Verdict:PASS - Both commits have valid subject prefixes for tag-check purposes.

The accepted prefixes are: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:.

Note: While tag-check passes (commits have the PENDING: prefix), check-patch-compliance fails because it enforces a stricter subset of prefixes that excludes PENDING: and QCLINUX:. This is a known discrepancy between the two checks.


Verdict

2 blockers to fix before merge:

  1. checkpatch (DT_SPLIT_BINDING): Split both commits to separate DT binding documentation/headers from driver implementation. This is a kernel submission requirement and should be fixed.

  2. check-patch-compliance (prefix): The PENDING: prefix causes this checker to fail. Options:

    • If patches have been posted upstream: Change to FROMLIST: and add Link: tags
    • If patches are vendor-only WIP: Accept that this checker will fail (known limitation)
    • Consider using QCLINUX: if these are vendor-specific changes with no upstream equivalent

Non-blockers:

  • All other checkers passed successfully
  • The tag-check requirement is satisfied (both commits have valid prefixes)

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1051

PR: #1051
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34484461705

Build Status: ✅ SUCCESS

Both kernel builds (standard and RT) completed successfully with no compilation errors.

Verdict

No compilation errors were found. The workflow failure was caused by test failures in the LAVA test suite, not by build/compilation issues. The PR changes compiled cleanly.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1051

PR: #1051
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34484461705

Build Status: ✅ SUCCESS (with warnings)

The kernel build completed successfully. The workflow failure was caused by a LAVA test submission failure (device type 'rb1' unavailable), not a compilation error.

However, the PR introduces 32 compilation warnings in the new pinctrl driver:

# Warning File:Line PR-introduced? Root Cause
1-32 'gpioN_pins' defined but not used drivers/pinctrl/qcom/pinctrl-qcs615-lpass-lpi.c:28-59 Yes Pin arrays declared but never referenced in pin groups

Verdict

All 32 warnings are introduced by this PR. The build succeeded, but the code quality should be improved by removing unused variables.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1051

PR: #1051
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34484461705

Build Status: ✅ COMPILATION SUCCEEDED

Both kernel builds (standard and RT) completed successfully. The workflow failure was caused by test job submission failures, not compilation errors.

Compilation Warnings

# Warning File:Line PR-introduced? Root Cause
1-32 'gpioX_pins' defined but not used drivers/pinctrl/qcom/pinctrl-qcs615-lpass-lpi.c:28-59 Yes New file introduces 32 unused pin array definitions

Verdict

No compilation errors found. The PR introduces 32 compiler warnings for unused variables in the new pinctrl driver file. These are non-fatal warnings that do not prevent the kernel from building successfully. The workflow failure was due to LAVA test job submission issues, not build failures.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1051

PR: #1051
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34484461705

# Error File:Line PR-introduced? Root Cause
N/A No compilation errors N/A N/A Build succeeded

Verdict

The kernel build completed successfully. Both the standard build and RT build passed without any compilation errors. The workflow failure was caused by test failures on hardware targets, not by build/compilation issues.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1051

PR: #1051
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34484461705

Build Status: ✅ SUCCESS

Both kernel builds completed successfully:

  • Standard build: ✅ Passed
  • RT build: ✅ Passed

Workflow Failure Root Cause

The workflow failed due to LAVA test infrastructure issues, NOT compilation errors:

Test Target Status Failure Reason
qrb2210-rb1 ❌ Failed LAVA job submission did not return a numeric job ID
shikra-iqs-evk ❌ Failed LAVA job failed during test execution

Compilation Errors: NONE

No compilation errors were found in either build log.

Verdict

This PR introduces NO build errors. The workflow failure is caused by test infrastructure issues (LAVA job submission/execution failures), not by code changes in the PR. The kernel builds cleanly for both standard and RT configurations.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1051

PR: #1051
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34484461705

Verdict

No compilation errors found. Both the standard kernel build and RT kernel build completed successfully. The workflow failure was caused by test failures in the LAVA test suite, not by compilation errors. This PR does not introduce any build-time issues.

Build Status:

  • ✅ Standard kernel build: SUCCESS
  • ✅ RT kernel build: SUCCESS
  • ❌ Test suite: FAILED (multiple test failures across different platforms)

The PR changes (ASoC talos-lyra support and QCS615 LPASS LPI pinctrl driver) compiled cleanly without errors or warnings.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1051

PR: #1051
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34484461705

Build Status: ✅ SUCCESS

Verdict: This PR introduces zero compilation errors. Both the standard kernel build and RT kernel build completed successfully. The workflow failure was caused by a test infrastructure issue (LAVA job submission failure for qrb2210-rb1), not by any compilation problems introduced by this PR.

Analysis Summary

Component Status Details
Standard Build ✅ Pass Completed successfully with no errors
RT Build ✅ Pass Completed successfully with no errors
Test Infrastructure ❌ Fail qrb2210-rb1 LAVA job submission failed (infrastructure issue)

Files Modified by PR

Patch 1/2: ASoC: qcom: sc8280xp: enable support for talos-lyra

  • Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
  • sound/soc/qcom/Kconfig
  • sound/soc/qcom/sc8280xp.c

Patch 2/2: pinctrl: qcom: add QCS615 LPASS LPI pinctrl driver

  • Documentation/devicetree/bindings/pinctrl/qcom,qcs615-lpass-lpi-pinctrl.yaml (new file)
  • arch/arm64/configs/defconfig
  • drivers/pinctrl/qcom/Kconfig
  • drivers/pinctrl/qcom/Makefile
  • drivers/pinctrl/qcom/pinctrl-qcs615-lpass-lpi.c (new file)

Conclusion

This PR is ready to merge from a build perspective. The workflow failure is unrelated to the code changes and is caused by test infrastructure (LAVA submission) issues that should be investigated separately.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1051

PR: #1051
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34484461705

Build Status: ✅ SUCCESS

Both the standard kernel build and RT kernel build completed successfully with no compilation errors.

Build Type Status Details
Standard Build ✅ Pass Completed successfully at 2026-09-10T14:51:15
RT Build ✅ Pass Completed successfully at 2026-09-10T14:05:19

Verdict

No compilation errors found. The PR builds cleanly. The workflow failure was caused by test failures, not build failures.

Note: The workflow was marked as failed due to test failures on hardware targets (e.g., KVM tests, Probe_Failure_Check, WiFi tests on monaco-evk, etc.), but these are runtime test failures, not compilation issues.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1051

PR: #1051
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34484461705

# Error File:Line PR-introduced? Root Cause
N/A Build succeeded with warnings N/A N/A The kernel build completed successfully. The workflow failed due to a LAVA test job submission failure for qrb2210-rb1, not a compilation error.

Compilation Warnings (Non-blocking)

The PR introduces 32 compiler warnings in drivers/pinctrl/qcom/pinctrl-qcs615-lpass-lpi.c:

  • Warning: 'gpio0_pins' through 'gpio31_pins' defined but not used [-Wunused-variable]
  • Location: drivers/pinctrl/qcom/pinctrl-qcs615-lpass-lpi.c:28-59
  • PR-introduced: Yes
  • Impact: Non-fatal warnings; build completes successfully

Verdict

The build succeeded. The workflow failure was caused by a LAVA test infrastructure issue (job submission failure for qrb2210-rb1), not by compilation errors. However, the PR introduces 32 unused variable warnings that should be addressed for code quality.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1051

PR: #1051
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34484461705

Build Status: ✅ SUCCESS

Both kernel builds completed successfully:

  • Standard build: ✅ Pass
  • RT build: ✅ Pass

Verdict

No compilation errors found. The workflow failed due to test failures (LAVA job submission and runtime test failures), not build failures. All code changes in this PR compiled cleanly.

📎 Detailed analysis: Full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants