Fix qup core icc votes - #1060
Salendarsingh Gaud (sgaud-quic) merged 2 commits into
Conversation
The GENI_TO_CORE ("qup-core") ICC vote selects the QUP Core 2X clock
rate. The CORE_2X_*_MHZ constants are expressed in Bps, but their
values are several orders of magnitude too small. For example, the
50 MHz threshold is represented by 2500 rather than 25000000 Bps.
As a result, clients using these constants can severely under-vote the
QUP Core clock.
Correct the constants to their intended Bps thresholds so that the ICC
provider selects the corresponding QUP Core 2X clock rate.
Link: https://lore.kernel.org/all/20260909-correct-icc-bandwidth-vote-constants-v1-1-fbebf6b3c341@oss.qualcomm.com/
Fixes: 58ffbba ("soc: qcom: geni: Support for ICC voting")
Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
…fter deep idle
At baud rates up to 115200, the serial console uses only a 1 kBps keepalive
vote for the GENI_TO_CORE ("qup-core") ICC path. This vote keeps the path
active but does not request a QUP Core 2X clock rate.
When the CPU enters a deeper idle state, the missing Core clock vote can
leave the console RX path unresponsive.
Use the 19.2 MHz Core 2X vote at low baud rates, while retaining the 50 MHz
vote at higher baud rates, so that console RX remains functional after deep
idle transitions.
Link: https://lore.kernel.org/all/20260909-correct-icc-bandwidth-vote-constants-v1-2-fbebf6b3c341@oss.qualcomm.com/
Fixes: 7cf563b ("tty: serial: qcom_geni_serial: Add interconnect support")
Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
|
Merge Check Failed: CR Not Eligible for Merge CR 4628868 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
|
qli-2.1 pull-request freeze |
Test Matrix
|
Test Matrix
|
Test Matrix
|
Test Matrix
|
ba034e7
into
qualcomm-linux:qcom-6.18.y
LAVA Failed Case Triage SummaryPR: #1060 Job 223447 | SoC monaco-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223447 Failed test cases in LAVA job 223447 (SoC: monaco-evk).
Job 223448 | SoC purwa-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223448 Failed test cases in LAVA job 223448 (SoC: purwa-evk).
Job 223449 | SoC shikra-iqs-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223449 Failed test cases in LAVA job 223449 (SoC: shikra-iqs-evk).
Job 223450 | SoC hamoa-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223450 Failed test cases in LAVA job 223450 (SoC: hamoa-evk).
Job 223451 | SoC qcs8300-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223451 Failed test cases in LAVA job 223451 (SoC: qcs8300-ride).
Job 223452 | SoC qcs6490-rb3gen2LAVA job: https://lava-oss.qualcomm.com/scheduler/job/223452 Failed test cases in LAVA job 223452 (SoC: qcs6490-rb3gen2).
Job 223453 | SoC qcs9100-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223453 Failed test cases in LAVA job 223453 (SoC: qcs9100-ride).
Job 223454 | SoC lemans-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223454 Failed test cases in LAVA job 223454 (SoC: lemans-evk).
Job 223455 | SoC qcs615-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223455 Failed test cases in LAVA job 223455 (SoC: qcs615-ride).
|
The GENI_TO_CORE ("qup-core") interconnect vote selects the QUP Core 2X
clock rate. The Core 2X bandwidth constants currently contain values that
are several orders of magnitude too small. Also, at baud rates up to
115200, the serial console uses only a 1 kBps keepalive vote, which does
not request a Core clock and can leave console RX unresponsive after the
system enters a deep CPU idle state.
Correct the common Core 2X bandwidth constants and use the 19.2 MHz Core
2X vote for the low-baud console path. Higher baud rates continue to use
the 50 MHz vote.
Patch 1 corrects the common Core 2X bandwidth constants. Patch 2 updates
the serial console's low-baud vote to use the corrected 19.2 MHz value.
CRs-fixed: 4628868
qli-2.1 pull-request freeze