Skip to content

RPI DSI Display on lemans and monaco - #1063

Closed
qti-ssmaurya wants to merge 3 commits into
qualcomm-linux:qcom-6.18.yfrom
qti-ssmaurya:rpi_lemans_monaco
Closed

qti-ssmaurya wants to merge 3 commits into
qualcomm-linux:qcom-6.18.yfrom
qti-ssmaurya:rpi_lemans_monaco

Conversation

@qti-ssmaurya

@qti-ssmaurya qti-ssmaurya commented Sep 9, 2026

Copy link
Copy Markdown

RPI 7" DSI Display with help of overlay on lemans and monaco

CRs-Fixed: 4669931

qti-ssmaurya and others added 2 commits September 9, 2026 17:37
 overlay

Add a DT overlay for the Raspberry Pi 7" DSI touchscreen panel on
Lemans EVK, using mdss0_dsi0 with 2 data lanes and the panel MCU on
I2C1.

Link: https://lore.kernel.org/all/20260907-rpi_dts_overlay-v2-2-a4989322ce00@oss.qualcomm.com/
Signed-off-by: Shashank Maurya <shashank.maurya@oss.qualcomm.com>
 overlay

Add a DT overlay for the Raspberry Pi 7" DSI touchscreen panel on
Monaco EVK, using mdss0_dsi0 with 2 data lanes and the panel MCU on
I2C8.

Link: https://lore.kernel.org/all/20260907-rpi_dts_overlay-v2-1-a4989322ce00@oss.qualcomm.com/
Signed-off-by: Shashank Maurya <shashank.maurya@oss.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

Signed-off-by: qti-ssmaurya <ssmaurya@qti.qualcomm.com>
@qti-ssmaurya
qti-ssmaurya deleted the rpi_lemans_monaco branch September 15, 2026 04:25
@qlijarvis

Copy link
Copy Markdown

PR #1063 — validate-patch

PR: #1063

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — both commits have correct lore.kernel.org links
  2. Lore link matches PR commits: Partial — diff content is faithful, but commit 1/2 has authorship mismatch; Makefile context differs (expected for vendor tree)
  3. Upstream patch status: ❌ NACKed — Bjorn Andersson rejected the series on 2026-09-07 due to unmet driver dependencies
  4. PR present in qcom-next/topics: Yes - all 2 commit(s) are present in qcom-next or topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1063
Verdict: ❌ FAIL


Commit 1/2: lemans-evk DSI overlay

Upstream commit: https://lore.kernel.org/all/20260907-rpi_dts_overlay-v2-2-a4989322ce00@oss.qualcomm.com/

Commit Message

Check Status Note
Subject matches upstream Subject adapted with FROMLIST: prefix (correct)
Body preserves rationale Key description preserved
Fixes tag present/correct N/A No Fixes tag in upstream or PR
Authorship preserved FAIL — PR author ssmaurya@qti.qualcomm.com differs from lore author shashank.maurya@oss.qualcomm.com
Backport note (if applicable) N/A Not a backport (FROMLIST)

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ⚠️ Context mismatch — PR inserts at different line number due to tree differences (expected)
arch/arm64/boot/dts/qcom/lemans-evk-raspberrypi-dsi-7inch.dtso Content identical to lore patch

Commit 2/2: monaco-evk DSI overlay

Upstream commit: https://lore.kernel.org/all/20260907-rpi_dts_overlay-v2-1-a4989322ce00@oss.qualcomm.com/

Commit Message

Check Status Note
Subject matches upstream Subject adapted with FROMLIST: prefix (correct)
Body preserves rationale Key description preserved
Fixes tag present/correct N/A No Fixes tag in upstream or PR
Authorship preserved PR author shashank.maurya@oss.qualcomm.com matches lore author
Backport note (if applicable) N/A Not a backport (FROMLIST)

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ⚠️ Context mismatch — PR inserts at different line number due to tree differences (expected)
arch/arm64/boot/dts/qcom/monaco-evk-raspberrypi-dsi-7inch.dtso Content identical to lore patch

Issues

Critical:

  1. Authorship mismatch (Commit 1/2) — The PR commit author for lemans-evk is Shashank Maurya <ssmaurya@qti.qualcomm.com>, but the lore patch author is Shashank Maurya <shashank.maurya@oss.qualcomm.com>. For FROMLIST: commits, the submitter may differ from the lore author, but the original author's Signed-off-by: must be present. The PR commit is missing the original author's sign-off.

    Fix: Add Signed-off-by: Shashank Maurya <shashank.maurya@oss.qualcomm.com> to commit 1/2, or amend the author to match the lore patch.

  2. Upstream patch status: NACKed — Bjorn Andersson (Qualcomm DT maintainer) explicitly rejected this series on the mailing list:

    "All I can do now is reject this series as well. Please send v2 once the driver changes has been merged and you have validated this again."

    The rejection reason: the series has unmet dependencies on regulator driver patches (prerequisite-message-id: <20260907-rpi_reg-v2-0-0c59aa60d31f@oss.qualcomm.com>) which themselves received change requests.

    Impact: Merging a NACKed patch into the vendor tree creates divergence from upstream and may cause integration issues when the revised upstream version is eventually accepted.


Verdict

❌ FAIL — Do not merge without correction.

Recommendation:

  1. Fix authorship for commit 1/2 (lemans-evk) — ensure the original lore author's Signed-off-by: is present, or amend the author to match the lore patch.

  2. Address the upstream NAK — The maintainer rejected this series due to missing driver dependencies. Options:

    • Wait for the prerequisite regulator driver patches to be revised, accepted, and merged upstream, then re-post this series (as the maintainer requested).
    • If the driver dependencies are already present in the vendor tree, document this in the commit message and explain why the vendor tree can safely merge these patches ahead of upstream acceptance.
    • If proceeding despite the NAK, change the prefix from FROMLIST: to PENDING: or QCLINUX: to signal that these patches are not on track for upstream acceptance in their current form.
  3. Verify dependencies — Confirm that the prerequisite regulator patches (message-id <20260907-rpi_reg-v2-0-0c59aa60d31f@oss.qualcomm.com>) are present in the vendor tree. If not, these DT overlays will not function correctly.


Final Summary

  1. Lore link present: Yes — both commits have correct lore.kernel.org links
  2. Lore link matches PR commits: Partial — diff content is faithful, but commit 1/2 has authorship mismatch; Makefile context differs (expected for vendor tree)
  3. Upstream patch status: ❌ NACKed — Bjorn Andersson rejected the series on 2026-09-07 due to unmet driver dependencies
  4. PR present in qcom-next/topics: Yes — integration_presence_report.md confirms both commits are present in topics (not qcom-next)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] FROMLIST: arm64: dts: qcom: lemans-evk: Add DSI display missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present
2/2 [PATCH 2/2] FROMLIST: arm64: dts: qcom: monaco-evk: Add DSI display missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present

Final Status

overall_status: PASS
present_commits: 2/2
partial_commits: 0/2
missing_commits: 0/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Yes - all 2 commit(s) are present in qcom-next or topics

@qlijarvis

Copy link
Copy Markdown

PR #1063 — checker-log-analyzer

PR: #1063
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34584105141

Checker Result Summary
Checker Result Summary
checkpatch 1 warning: email mismatch (From vs Signed-off-by)
dt-binding-check ⏭️ Skipped — no binding changes
dtb-check Multiple schema validation errors (pre-existing + new)
sparse-check ⏭️ Skipped — no C/H changes
check-uapi-headers ⏭️ Skipped — no UAPI changes
check-patch-compliance Author mismatch on commit 1
tag-check Both commits have FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1063 — arm64: dts: qcom: Add DSI display overlays for lemans-evk and monaco-evk
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/34584105141
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch 1 warning: email mismatch (From vs Signed-off-by)
dt-binding-check ⏭️ Skipped — no binding changes
dtb-check Multiple schema validation errors (pre-existing + new)
sparse-check ⏭️ Skipped — no C/H changes
check-uapi-headers ⏭️ Skipped — no UAPI changes
check-patch-compliance Author mismatch on commit 1
tag-check Both commits have FROMLIST: prefix

❌ checkpatch

Root cause: Email address mismatch between From: and Signed-off-by: in commit abccec7.

Failure details:

Commit abccec74a185 ("FROMLIST: arm64: dts: qcom: lemans-evk: Add DSI display  overlay")
WARNING: From:/Signed-off-by: email address mismatch: 
  'From: Shashank Maurya <ssmaurya@qti.qualcomm.com>' != 
  'Signed-off-by: Shashank Maurya <shashank.maurya@oss.qualcomm.com>'

Fix: Align the From: email with the Signed-off-by: email. Use the OSS email consistently:

git rebase -i 84dccf2afd18   # mark commit abccec74a185 as 'edit'
git commit --amend --author="Shashank Maurya <shashank.maurya@oss.qualcomm.com>"
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 84dccf2afd18..8e2201afd2f1

❌ check-patch-compliance

Root cause: Author mismatch between the lore patch and the git commit for commit abccec7.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: lemans-evk: Add DSI display  overlay
Author mismatch:
  Original author: Shashank Maurya <shashank.maurya@oss.qualcomm.com>
  Commit author : Shashank Maurya <ssmaurya@qti.qualcomm.com>

Fix: Same as checkpatch — use the OSS email address consistently:

git commit --amend --author="Shashank Maurya <shashank.maurya@oss.qualcomm.com>"

❌ dtb-check

Root cause: Multiple schema validation errors — a mix of pre-existing tree issues and new errors introduced by the overlay.

Failure details:

Pre-existing tree issues (not caused by this PR):

  • usb-typec@67 (ti,hd3ss3220): 'wakeup-source' does not match any of the regexes — pre-existing in base DTB
  • video-codec@aa00000 (qcom,sa8775p-iris): 'iommus' is a required property — pre-existing in base DTB
  • ethernet@23040000 (qcom,sa8775p-ethqos): Unevaluated properties (interconnect-names, interconnects) — pre-existing in base DTB
  • cci@ac13000, cci@ac14000, cci@ac15000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected — pre-existing in monaco.dtsi
  • pinctrl@f100000 (qcom,qcs8300-tlmm): Unevaluated properties (usb1-hs-sel-switch-hog, usb1-hub-reset-hog) — pre-existing in monaco-evk.dts
  • pinctrl@f000000 (qcom,sa8775p-tlmm): gp_mn_active-state: 'gp_mn' is not one of [...] — pre-existing in lemans-evk.dts

New errors introduced by the overlay:

  1. i2c@984000 / i2c@a80000 (qcom,geni-i2c): Unevaluated properties (qcom,load-firmware, qcom,xfer-mode)

    • Root cause: The qcom,i2c-geni-qcom.yaml binding does not declare these vendor-specific properties.
    • Fix: Add qcom,load-firmware and qcom,xfer-mode to the qcom,i2c-geni-qcom.yaml binding schema, or remove them from the overlay if they are not required.
  2. reg_backlight@45 (raspberrypi,touchscreen-panel-regulator-v2): 'vcc-supply' does not match any of the regexes

    • Root cause: The raspberrypi,7inch-touchscreen-panel-regulator-v2.yaml binding does not declare vcc-supply.
    • Fix: Add vcc-supply to the binding schema, or use a different property name if the binding expects something else.
  3. panel@0 (raspberrypi,dsi-7inch): 'iovcc-supply', 'port' do not match any of the regexes and compatible: ['raspberrypi,dsi-7inch'] is too short

    • Root cause: The panel is being validated against ilitek,ili9881c.yaml instead of a dedicated raspberrypi,dsi-7inch binding.
    • Fix: Add a dedicated binding YAML for raspberrypi,dsi-7inch, or add raspberrypi,dsi-7inch to an existing panel binding that supports it.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/lemans-evk-raspberrypi-dsi-7inch.dtb
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/monaco-evk-raspberrypi-dsi-7inch.dtb

Verdict

3 blockers must be fixed before merge:

  1. checkpatch + check-patch-compliance: Fix the email mismatch in commit abccec7 — use shashank.maurya@oss.qualcomm.com consistently in both From: and Signed-off-by:.

  2. dtb-check (new errors): The overlay introduces 3 new schema validation errors:

    • qcom,load-firmware and qcom,xfer-mode are not declared in the I2C binding
    • vcc-supply is not declared in the Raspberry Pi regulator binding
    • raspberrypi,dsi-7inch panel has no dedicated binding and is being validated against the wrong schema

    Recommended action: Either add the missing properties to the upstream bindings (requires separate patches), or remove/adjust the properties in the overlay to match the existing bindings. The pre-existing dtb-check errors are not blockers for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants