Skip to content

hwmon: Add Qualcomm SPMI BCL driver - #892

Merged
Salendarsingh Gaud (sgaud-quic) merged 12 commits into
qualcomm-linux:qcom-6.18.yfrom
dmantre:bcl_v2
Aug 30, 2026
Merged

Salendarsingh Gaud (sgaud-quic) merged 12 commits into
qualcomm-linux:qcom-6.18.yfrom
dmantre:bcl_v2

Conversation

@dmantre

@dmantre dmantre commented Aug 3, 2026

Copy link
Copy Markdown

Revert the existing changes and upadted as per BCL v2 patch series.

CRs-Fixed: 4476647

@quic-manafm

Copy link
Copy Markdown

LGTM

Comment thread arch/arm64/configs/qcom.config
@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ◻️
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Ethernet ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

@sgaud-quic

Copy link
Copy Markdown
Contributor

dmantre please rebase this on tip

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #892

PR: #892
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32361335384

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during PR integration arch/arm64/configs/qcom.config Yes The PR modifies the same config line that was changed in the base branch after the PR was created. PR removes CONFIG_SENSORS_QCOM_BCL=y (patch 1/12) and adds CONFIG_SENSORS_QCOM_SPMI_BCL=y (patch 12/12), but the base branch has conflicting changes to the same region.

Verdict

This is a merge conflict, not a compilation error. The build failed during the git merge phase before any compilation could occur. The PR needs to be rebased on the latest qcom-6.18.y branch to resolve the conflict in arch/arm64/configs/qcom.config.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #892

PR: #892
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32361335384

# Error File:Line PR-introduced? Root Cause
1 Merge conflict arch/arm64/configs/qcom.config Yes PR modifies qcom.config (removes CONFIG_SENSORS_QCOM_BCL, adds CONFIG_SENSORS_QCOM_SPMI_BCL) but the target branch has conflicting changes in the same region

Verdict

This is a merge conflict, not a compilation error. The build failed during the git merge step before any code was compiled. The PR needs to be rebased on the latest qcom-6.18.y branch to resolve the conflict in arch/arm64/configs/qcom.config.

📎 Detailed analysis: Full report

dmantre and others added 12 commits August 25, 2026 17:26
This reverts commit 11e8f87.

These changes are superseded by the BCL v2 patch series.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
This reverts commit f936a52.

These changes are superseded by the BCL v2 patch series.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
This reverts commit e02e7a0.

These changes are superseded by the BCL v2 patch series.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
This reverts commit 37c3507.

These changes are superseded by the BCL v2 patch series.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
This reverts commit 25dd59f.

These changes are superseded by the BCL v2 patch series.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
Qualcomm SPMI PMIC BCL (Battery Current Limiting) is a safety feature
that monitors battery or system voltage and current to alert system
for overcurrent or undervoltage conditions.

It provides:
- Real-time voltage and current monitoring
- Configurable thresholds per channel
- Hardware interrupts when thresholds are violated

Add a DeviceTree binding to describe the BCL on Qualcomm's PMICs.

Add sensor type to SPMI device list for BCL device.

Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260722-qcom-bcl-hwmon-v2-1-febe2805e17b@oss.qualcomm.com
Add driver for Qualcomm SPMI PMIC Battery Current Limiting (BCL)
hardware monitor. The driver exposes battery voltage and current
monitoring through hwmon interface.

The BCL driver provides
- Real-time voltage and current readings
- Configurable threshold-based alarms
- Interrupt-driven notifications when thresholds are exceeded
- Automatic threshold management with polling-based recovery
- Hardware-specific scaling factors and threshold representations

Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260722-qcom-bcl-hwmon-v2-2-febe2805e17b@oss.qualcomm.com
Add Battery Current Limiting (BCL) hardware monitor node for pm7250b
PMIC. The BCL monitors battery voltage and current, providing hardware
interrupts when configurable thresholds are violated.

Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260722-qcom-bcl-hwmon-v2-3-febe2805e17b@oss.qualcomm.com
Add Battery Current Limiting (BCL) hardware monitor node for
hamoa-pmic. The BCL monitors battery voltage and current, providing
hardware interrupts when configurable thresholds are violated.

Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260722-qcom-bcl-hwmon-v2-4-febe2805e17b@oss.qualcomm.com
Add Battery Current Limiting (BCL) hardware monitor node for pm8350c
PMIC. The BCL monitors battery voltage and current, providing hardware
interrupts when configurable thresholds are violated.

Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260722-qcom-bcl-hwmon-v2-5-febe2805e17b@oss.qualcomm.com
Add Battery Current Limiting (BCL) hardware monitor node for pm8550
PMIC. The BCL monitors battery voltage and current, providing hardware
interrupts when configurable thresholds are violated.

Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260722-qcom-bcl-hwmon-v2-7-febe2805e17b@oss.qualcomm.com
Enable Qualcomm BCL driver config.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
@dmantre

dmantre commented Aug 25, 2026

Copy link
Copy Markdown
Author

Done

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia purwa-iot-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet_Basic_Validation ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ❌ Fail ❌ Fail ⚠️ skip
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
KVM_Driver ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_EL2_DTB ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_Infra ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
USBHost ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail
WiFi_Firmware_Driver ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ✅ Pass ✅ Pass ❌ Fail ✅ Pass
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass

@sgaud-quic
Salendarsingh Gaud (sgaud-quic) merged commit 7c730ee into qualcomm-linux:qcom-6.18.y Aug 30, 2026
6 of 8 checks passed
@qlijarvis

Copy link
Copy Markdown

PR #892 — validate-patch

PR: #892

Verdict Issues Detailed Report
⚠️ 8 Full report

Final Summary

  1. Lore link present: Yes - all FROMLIST commits include correct Link: tags to lore v2 series (20260722-qcom-bcl-hwmon-v2-*)
  2. Lore link matches PR commits: Yes - commit messages and diff content faithfully match lore v2 patches 01/10, 02/10, 03/10, 04/10, 05/10, and 07/10
  3. Upstream patch status: ⏳ Decision Pending - posted July 22, 2026; under active review by Guenter Roeck (hwmon) and Krzysztof Kozlowski (DT); change requests issued; no acceptance signal yet
  4. PR present in qcom-next/topics: Fail - 2/12 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #892 - "hwmon: Add Qualcomm SPMI BCL driver (v2)"
Upstream commits: https://lore.kernel.org/r/20260722-qcom-bcl-hwmon-v2-0-febe2805e17b@oss.qualcomm.com (series)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream All FROMLIST commits match lore v2 series subjects
Body preserves rationale Commit messages faithfully preserve lore patch descriptions
Fixes tag present/correct N/A No Fixes tags in upstream patches
Authorship preserved All FROMLIST commits correctly preserve Manaf Meethalavalappu Pallikunhi as author
Backport note (if applicable) N/A FROMLIST prefix used (not BACKPORT)
Link tags present All FROMLIST commits include correct lore.kernel.org Link: tags

Diff

File Status Notes
arch/arm64/configs/qcom.config (01/12) Revert of QCLINUX commit - vendor-only, no lore validation needed
arch/arm64/boot/dts/qcom/pm8350c.dtsi (02/12) Revert of FROMLIST commit - present in qcom-next
arch/arm64/boot/dts/qcom/pm7250b.dtsi (03/12) Revert of FROMLIST commit - present in qcom-next
drivers/hwmon/qcom-bcl-hwmon.c (04/12) ⚠️ Revert of FROMLIST commit - missing from qcom-next/topics
Documentation/devicetree/bindings/hwmon/qcom,pm7250b-bcl.yaml (05/12) ⚠️ Revert of FROMLIST commit - missing from qcom-next/topics
Documentation/devicetree/bindings/hwmon/qcom,pm7250b-bcl.yaml (06/12) Matches lore v2 01/10 - present in qcom-next
drivers/hwmon/qcom-bcl-hwmon.c (07/12) Matches lore v2 02/10 - present in qcom-next
arch/arm64/boot/dts/qcom/pm7250b.dtsi (08/12) Matches lore v2 03/10 - present in qcom-next
arch/arm64/boot/dts/qcom/hamoa-pmic.dtsi (09/12) Matches lore v2 04/10 - present in qcom-next
arch/arm64/boot/dts/qcom/pm8350c.dtsi (10/12) Matches lore v2 05/10 - present in qcom-next
arch/arm64/boot/dts/qcom/pm8550.dtsi (11/12) Matches lore v2 07/10 - present in qcom-next
arch/arm64/configs/qcom.config (12/12) QCLINUX commit - vendor-only, present in qcom-next

Issues

Integration Presence Failures:

  • Commits 04/12 and 05/12 (reverts of old BCL v1 driver and bindings) are missing from both qcom-next and topics. These revert commits reference old FROMLIST patches that were apparently never merged to qcom-next, yet the PR description states they are being superseded by the v2 series.
  • The integration_presence_report.md shows commit 01/12 as "partial" - subject evidence found but full change not verified in qcom-next.

Upstream Status:

  • The lore v2 series (posted July 22, 2026) is under active review - not yet accepted.
  • Guenter Roeck (hwmon maintainer) provided review feedback requesting changes to label handling in the driver.
  • Krzysztof Kozlowski (DT maintainer) is also engaged in the thread.
  • No "applied", "queued", or formal Acked-by/Reviewed-by tags found in the fetched lore threads.
  • The patches are not yet merged to torvalds/linux mainline or stable trees.

Prefix Consistency:

  • Using FROMLIST: prefix is inconsistent with the actual upstream status - these patches are still under review and have not been accepted. The FROMLIST: prefix typically indicates patches that have been posted and are awaiting merge, but given active review feedback requesting changes, these should arguably use PENDING: or wait for upstream acceptance before merging.

Verdict

Do not merge yet. The PR has three significant issues:

  1. Upstream patches not accepted - The lore v2 series is under active review with change requests from the hwmon maintainer. Merging FROMLIST commits before upstream acceptance risks divergence if the upstream patches are revised.

  2. Missing revert targets - Commits 04/12 and 05/12 attempt to revert patches that don't exist in qcom-next/topics, suggesting the old BCL v1 patches were never merged to the integration branch. These revert commits should be dropped.

  3. Integration presence failures - 2 of 12 commits are missing from qcom-next/topics, violating the requirement that all PR commits must be present in the integration branch before merging.

Recommended actions:

  1. Drop commits 04/12 and 05/12 (reverts of non-existent commits)
  2. Wait for upstream acceptance of the lore v2 series before merging
  3. Once accepted upstream, update commit prefixes from FROMLIST: to UPSTREAM: or BACKPORT: as appropriate
  4. Verify all commits are present in qcom-next before re-submitting

Final Summary

  1. Lore link present: Yes - all FROMLIST commits include correct Link: tags to lore v2 series (20260722-qcom-bcl-hwmon-v2-*)
  2. Lore link matches PR commits: Yes - commit messages and diff content faithfully match lore v2 patches 01/10, 02/10, 03/10, 04/10, 05/10, and 07/10
  3. Upstream patch status: ⏳ Decision Pending - posted July 22, 2026; under active review by Guenter Roeck (hwmon) and Krzysztof Kozlowski (DT); change requests issued; no acceptance signal yet
  4. PR present in qcom-next/topics: Fail - 2/12 commits (04/12, 05/12) missing from both qcom-next and topics; 1/12 commit (01/12) shows only partial evidence

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/12 [PATCH 01/12] Revert "QCLINUX: defconfig: Enable Qualcomm BCL driver" partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
2/12 [PATCH 02/12] Revert "FROMLIST: arm64: dts: qcom: pm8350c: Enable present - exact patch-id match at 40b5a75 skipped - not checked because qcom-next already contains the change present
3/12 [PATCH 03/12] Revert "FROMLIST: arm64: dts: qcom: pm7250b: Enable present - exact patch-id match at ec68eb9 skipped - not checked because qcom-next already contains the change present
4/12 [PATCH 04/12] Revert "FROMLIST: hwmon: Add Qualcomm PMIC BCL hardware missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
5/12 [PATCH 05/12] Revert "FROMLIST: dt-bindings: hwmon: Add missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
6/12 [PATCH 06/12] FROMLIST: dt-bindings: hwmon: Describe Qualcomm BCL present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
7/12 [PATCH 07/12] FROMLIST: hwmon: Add Qualcomm PMIC BCL driver present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
8/12 [PATCH 08/12] FROMLIST: arm64: dts: qcom: pm7250b: Enable BCL sensor present - exact patch-id match at 9311558 skipped - not checked because qcom-next already contains the change present
9/12 [PATCH 09/12] FROMLIST: arm64: dts: qcom: hamoa-pmic: Enable BCL present - exact patch-id match at 45bc353 skipped - not checked because qcom-next already contains the change present
10/12 [PATCH 10/12] FROMLIST: arm64: dts: qcom: pm8350c: Enable BCL sensor present - exact patch-id match at b88b814 skipped - not checked because qcom-next already contains the change present
11/12 [PATCH 11/12] FROMLIST: arm64: dts: qcom: pm8550: Enable BCL sensor present - exact patch-id match at 527ae65 skipped - not checked because qcom-next already contains the change present
12/12 [PATCH 12/12] QCLINUX: defconfig: Enable Qualcomm BCL driver present - all checked added lines are present skipped - not checked because qcom-next already contains the change present

Final Status

overall_status: FAIL
present_commits: 9/12
partial_commits: 1/12
missing_commits: 2/12
topics_checked_for_commits: 3/12
final_summary: PR present in qcom-next/topics: Fail - 2/12 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #892 — checker-log-analyzer

PR: #892
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32839112657

Checker Result Summary
Checker Result Summary
checkpatch 2 warnings in 2 commits
dt-binding-check All binding checks passed
dtb-check All DTB validation passed
sparse-check No sparse errors
check-uapi-headers No UAPI issues
check-patch-compliance 6 prefix failures + 1 content mismatch
tag-check 5 commits missing required prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #892 - BCL hwmon driver updates
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32839112657
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch 2 warnings in 2 commits
dt-binding-check All binding checks passed
dtb-check All DTB validation passed
sparse-check No sparse errors
check-uapi-headers No UAPI issues
check-patch-compliance 6 prefix failures + 1 content mismatch
tag-check 5 commits missing required prefix

❌ checkpatch

Root cause: Two commits have style warnings that should be reviewed.

Failure details:

Commit 5c91732 - Revert "FROMLIST: dt-bindings: hwmon: Add qcom,bcl-hwmon yaml bindings":

WARNING: DT binding docs and includes should be a separate patch.
total: 0 errors, 2 warnings, 0 checks, 10 lines checked

Commit 62d0145 - FROMLIST: hwmon: Add Qualcomm PMIC BCL driver:

WARNING: struct reg_field should normally be const
#1380: FILE: drivers/hwmon/qcom-bcl-hwmon.c:1315:
+		struct reg_field field = data->reg_fields[i];
total: 0 errors, 1 warnings, 0 checks, 1467 lines checked

Fix:

  1. Revert commit warning - This is a false positive. Revert commits naturally touch both binding docs and includes together because they're reverting a previous commit. This warning can be ignored for revert commits.

  2. reg_field const warning - Consider making the local variable const:

    git rebase -i dc0f4d4280a7   # mark commit 62d01450875c as 'edit'
    # Edit drivers/hwmon/qcom-bcl-hwmon.c:1315
    # Change: struct reg_field field = data->reg_fields[i];
    # To:     const struct reg_field field = data->reg_fields[i];
    git add drivers/hwmon/qcom-bcl-hwmon.c
    git commit --amend --no-edit
    git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git dc0f4d4280a7..f51c1bd6026b440166c6b95c86a9b649405113af

❌ check-patch-compliance

Root cause: Six commits have subject lines that don't start with an accepted prefix, and one commit has content differences from its upstream link.

Failure details:

Prefix failures (6 commits):

Checking commit: Revert "QCLINUX: defconfig: Enable Qualcomm BCL driver"
Commit summary does not start with a required prefix

Checking commit: Revert "FROMLIST: arm64: dts: qcom: pm8350c: Enable Qualcomm BCL device"
Commit summary does not start with a required prefix

Checking commit: Revert "FROMLIST: arm64: dts: qcom: pm7250b: Enable Qualcomm BCL device"
Commit summary does not start with a required prefix

Checking commit: Revert "FROMLIST: hwmon: Add Qualcomm PMIC BCL hardware monitor driver"
Commit summary does not start with a required prefix

Checking commit: Revert "FROMLIST: dt-bindings: hwmon: Add qcom,bcl-hwmon yaml bindings"
Commit summary does not start with a required prefix

Checking commit: QCLINUX: defconfig: Enable Qualcomm BCL driver
Commit summary does not start with a required prefix

Content mismatch (1 commit):

Checking commit: FROMLIST: hwmon: Add Qualcomm PMIC BCL driver
Change is different from the one mentioned in Link
Link: https://lore.kernel.org/r/20260722-qcom-bcl-hwmon-v2-2-febe2805e17b@oss.qualcomm.com

Fix:

For the 5 Revert commits: Add a prefix before Revert. The checker requires every commit to start with an accepted prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). For revert commits, add the appropriate prefix before the word "Revert":

git rebase -i dc0f4d4280a7
# Mark all 5 revert commits as 'edit'

# For each revert commit:
git commit --amend -m "FROMLIST: Revert \"FROMLIST: ...\""
# or
git commit --amend -m "UPSTREAM: Revert \"QCLINUX: ...\""

git rebase --continue

Choose the prefix based on where the revert itself should be posted:

  • If the revert will be posted to lore → FROMLIST: Revert "..."
  • If the revert is already upstream → UPSTREAM: Revert "..."

For the QCLINUX commit: The QCLINUX: prefix is not accepted by check-patch-compliance. This is a known checker limitation — the checker only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). If this is a vendor-only config change with no upstream equivalent, the checker will always fail. You have two options:

  1. Accept the failure (known limitation for vendor-only commits)
  2. If the change will be posted upstream, change to FROMLIST: and add a Link: tag

For the content mismatch: Fetch the upstream patch and compare:

b4 am --single-message -C -l -3 https://lore.kernel.org/r/20260722-qcom-bcl-hwmon-v2-2-febe2805e17b@oss.qualcomm.com -o /tmp/bcl
git format-patch -1 62d01450875c --stdout > /tmp/pr-patch
diff <(awk '/^diff/,/^--$/' /tmp/pr-patch | grep -E '^[+-][^+-]') \
     <(awk '/^diff/,/^--$/' /tmp/bcl/*.mbx | grep -E '^[+-][^+-]')

Classify the differences:

  • Context-only shift → not a real issue
  • Legitimate adaptation (e.g., for backport) → document in commit message
  • Missing hunk → add it
  • Extra hunk → remove or attribute separately

Reproduce locally:

cd /path/to/kernel
bash /path/to/kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base dc0f4d4280a7 \
  --head f51c1bd6026b440166c6b95c86a9b649405113af

❌ tag-check

Root cause: Five commits have subject lines that don't start with a required prefix tag. The target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), so every commit must start with one of: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:.

Failure details:

The following commits are missing a prefix before the word "Revert":

  1. Revert "QCLINUX: defconfig: Enable Qualcomm BCL driver"
  2. Revert "FROMLIST: arm64: dts: qcom: pm8350c: Enable Qualcomm BCL device"
  3. Revert "FROMLIST: arm64: dts: qcom: pm7250b: Enable Qualcomm BCL device"
  4. Revert "FROMLIST: hwmon: Add Qualcomm PMIC BCL hardware monitor driver"
  5. Revert "FROMLIST: dt-bindings: hwmon: Add qcom,bcl-hwmon yaml bindings"

Fix:

Add a prefix before each Revert commit subject:

git rebase -i dc0f4d4280a7
# Mark all 5 revert commits as 'edit'

# For each commit, amend the subject to add a prefix:
git commit --amend -m "FROMLIST: Revert \"FROMLIST: original subject\""
# or
git commit --amend -m "UPSTREAM: Revert \"QCLINUX: original subject\""

git rebase --continue

Choose the correct prefix based on the revert's origin:

  • Posted to lore but not yet merged → FROMLIST:
  • In a maintainer tree → FROMGIT:
  • Merged into Linus's tree → UPSTREAM:
  • Vendor-only revert → QCLINUX: (but note: this will still fail check-patch-compliance)

Reproduce locally:

git log dc0f4d4280a7..f51c1bd6026b440166c6b95c86a9b649405113af --format="%H %s" | \
while read sha subject; do
  if ! echo "$subject" | grep -qE '^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'; then
    echo "❌ MISSING prefix: $sha $subject"
  fi
done

Verdict

7 blockers must be fixed before merge:

  1. checkpatch - 1 real warning (reg_field const) + 1 false positive (revert DT binding split)
  2. check-patch-compliance - 6 prefix failures (5 Revert commits + 1 QCLINUX commit) + 1 content mismatch
  3. tag-check - 5 commits missing required prefix before "Revert"

Priority fixes:

  1. Add prefix to all 5 Revert commits (fixes both check-patch-compliance and tag-check)
  2. Investigate content mismatch in commit 62d0145
  3. Consider making reg_field const in drivers/hwmon/qcom-bcl-hwmon.c:1315
  4. Accept QCLINUX: prefix failure as a known limitation (or change to FROMLIST: if posting upstream)

@qlijarvis

Copy link
Copy Markdown

PR #892 — validate-patch

PR: #892

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Yes for commits 6-11 (FROMLIST); No for commits 1-5 (reverts) and 12 (QCLINUX) - as expected
  2. Lore link matches PR commits: Yes - commits 6-11 faithfully represent lore v2 patches 1,2,3,4,5,7; MAINTAINERS context difference is due to base tree, not patch error
  3. Upstream patch status: ⏳ Decision Pending - v2 series posted July 22, 2026; active review with hwmon maintainer Guenter Roeck; no applied/queued signal yet; no rejection; positive collaboration on implementation details
  4. PR present in qcom-next/topics: Fail - 2/12 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #892 - BCL v2 driver series with reverts
Upstream commits: https://lore.kernel.org/r/20260722-qcom-bcl-hwmon-v2-0-febe2805e17b@oss.qualcomm.com (v2 series)
Verdict: ⚠️ PARTIAL

Summary

This PR contains 12 commits:

  • Commits 1-5: Revert old BCL patches (1 QCLINUX, 4 FROMLIST) - no lore links required
  • Commits 6-11: New FROMLIST patches from lore v2 series - have lore links
  • Commit 12: QCLINUX defconfig - no lore link required

The FROMLIST commits (6-11) correspond to lore v2 patches 1,2,3,4,5,7 from the 10-patch series. The PR omits lore v2 patches 6,8,9,10 (additional DTS enablement for pmh0101, pmih0108-kaanapali, pmih0108, smb2370).

Commit Message Analysis

Commit Check Status Note
1-5 (Reverts) Lore link Revert commits - no lore link expected
6 (dt-bindings) Subject matches Matches lore v2-1
6 Body preserves rationale Identical to upstream
6 Authorship Manaf Meethalavalappu Pallikunhi - matches lore
6 Link tag Correct lore URL
7 (hwmon driver) Subject matches Matches lore v2-2
7 Body preserves rationale Identical to upstream
7 Authorship Matches lore
7 Link tag Correct lore URL
8-11 (DTS) All checks Match lore v2-3,4,5,7 respectively
12 (QCLINUX) Lore link QCLINUX prefix - no lore link expected

Diff Comparison

File Status Notes
Documentation/devicetree/bindings/hwmon/qcom,pm7250b-bcl.yaml Identical to lore v2-1
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml Identical to lore v2-1
MAINTAINERS (commit 6) ⚠️ PR has 8 lines, lore has 7 lines - context difference in QUALCOMM BLUETOOTH DRIVER section (missing M: Bartosz Golaszewski line in PR base tree)
drivers/hwmon/qcom-bcl-hwmon.c Matches lore v2-2 (not fully verified due to size, but header/structure match)
arch/arm64/boot/dts/qcom/*.dtsi DTS changes match lore patches
arch/arm64/configs/qcom.config Vendor-specific config changes

Upstream Patch Status

Commit Community Verdict
v2-1 (dt-bindings) Decision Pending — Active review with Guenter Roeck (hwmon maintainer); last activity Aug 13, 2026; discussion on lemergency attribute naming and implementation
v2-2 (hwmon driver) Decision Pending — Under active review; maintainer feedback being addressed
v2-3 through v2-7 (DTS) Decision Pending — Part of same series under review

Evidence: The lore thread shows active collaboration between the author (Manaf Meethalavalappu Pallikunhi) and hwmon maintainer Guenter Roeck. Discussion topics include:

  • Dynamic vs static attribute initialization (resolved - will use static with is_visible)
  • Third alarm threshold support (lemergency attribute)
  • Maintainer is actively working on extending hwmon core to support the third threshold

No "applied", "queued", or "merged" signals found. No NAK or rejection signals. Series is v2 (posted July 22, 2026), indicating v1 feedback was addressed.

Integration Presence (from integration_presence_report.md)

Commit qcom-next topics Final
1/12 (Revert QCLINUX) partial partial partial
2/12 (Revert FROMLIST pm8350c) present (40b5a75) skipped present
3/12 (Revert FROMLIST pm7250b) present (ec68eb9) skipped present
4/12 (Revert FROMLIST hwmon) missing missing missing
5/12 (Revert FROMLIST dt-bindings) missing missing missing
6/12 (FROMLIST dt-bindings v2) present skipped present
7/12 (FROMLIST hwmon v2) present skipped present
8/12 (FROMLIST pm7250b v2) present (9311558) skipped present
9/12 (FROMLIST hamoa-pmic v2) present (45bc353) skipped present
10/12 (FROMLIST pm8350c v2) present (b88b814) skipped present
11/12 (FROMLIST pm8550 v2) present (527ae65) skipped present
12/12 (QCLINUX defconfig) present skipped present

Status: 9/12 present, 1/12 partial, 2/12 missing

Issues Found

  1. Missing commits in qcom-next/topics (commits 4 & 5): The revert commits for the old FROMLIST hwmon driver and dt-bindings are not present in qcom-next or topics. This suggests these old patches may not have been merged to qcom-next in the first place, making the reverts unnecessary or the reverts need to be applied to qcom-next.

  2. MAINTAINERS context difference (commit 6): The PR's MAINTAINERS patch shows a different context for the QUALCOMM BLUETOOTH DRIVER section compared to lore. The lore version includes M: Bartosz Golaszewski <brgl@kernel.org> but the PR base tree doesn't have this line. This is a legitimate base tree difference, not a patch error.

  3. Incomplete series: The PR includes only 6 of 10 patches from the lore v2 series (patches 1,2,3,4,5,7). Missing patches 6,8,9,10 enable BCL for additional PMICs (pmh0101, pmih0108-kaanapali, pmih0108, smb2370). This is intentional partial integration.

Verdict

Merge with caution - The FROMLIST commits (6-11) faithfully represent their upstream lore sources. However:

  1. Integration concern: Commits 4 & 5 (reverts of old FROMLIST patches) are missing from qcom-next/topics, which may indicate:

    • The old patches were never merged to qcom-next (making reverts unnecessary), OR
    • The reverts need to be applied to qcom-next first
  2. Upstream status: The lore series is under active review (Decision Pending) with positive maintainer engagement. Using FROMLIST: prefix is appropriate.

  3. Authorship: All FROMLIST commits correctly preserve the original author (Manaf Meethalavalappu Pallikunhi) in the From: field and include proper Link: tags.

  4. Completeness: This is a partial integration of the 10-patch lore series. The omitted patches (v2-6,8,9,10) enable BCL for additional PMIC variants not needed in this integration.

Final Summary

  1. Lore link present: Yes for commits 6-11 (FROMLIST); No for commits 1-5 (reverts) and 12 (QCLINUX) - as expected
  2. Lore link matches PR commits: Yes - commits 6-11 faithfully represent lore v2 patches 1,2,3,4,5,7; MAINTAINERS context difference is due to base tree, not patch error
  3. Upstream patch status: ⏳ Decision Pending - v2 series posted July 22, 2026; active review with hwmon maintainer Guenter Roeck; no applied/queued signal yet; no rejection; positive collaboration on implementation details
  4. PR present in qcom-next/topics: Partial - 9/12 commits present, 1/12 partial, 2/12 missing (commits 4 & 5 - the old FROMLIST reverts are not in qcom-next/topics)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/12 [PATCH 01/12] Revert "QCLINUX: defconfig: Enable Qualcomm BCL driver" partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
2/12 [PATCH 02/12] Revert "FROMLIST: arm64: dts: qcom: pm8350c: Enable present - exact patch-id match at 40b5a75 skipped - not checked because qcom-next already contains the change present
3/12 [PATCH 03/12] Revert "FROMLIST: arm64: dts: qcom: pm7250b: Enable present - exact patch-id match at ec68eb9 skipped - not checked because qcom-next already contains the change present
4/12 [PATCH 04/12] Revert "FROMLIST: hwmon: Add Qualcomm PMIC BCL hardware missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
5/12 [PATCH 05/12] Revert "FROMLIST: dt-bindings: hwmon: Add missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
6/12 [PATCH 06/12] FROMLIST: dt-bindings: hwmon: Describe Qualcomm BCL present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
7/12 [PATCH 07/12] FROMLIST: hwmon: Add Qualcomm PMIC BCL driver present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
8/12 [PATCH 08/12] FROMLIST: arm64: dts: qcom: pm7250b: Enable BCL sensor present - exact patch-id match at 9311558 skipped - not checked because qcom-next already contains the change present
9/12 [PATCH 09/12] FROMLIST: arm64: dts: qcom: hamoa-pmic: Enable BCL present - exact patch-id match at 45bc353 skipped - not checked because qcom-next already contains the change present
10/12 [PATCH 10/12] FROMLIST: arm64: dts: qcom: pm8350c: Enable BCL sensor present - exact patch-id match at b88b814 skipped - not checked because qcom-next already contains the change present
11/12 [PATCH 11/12] FROMLIST: arm64: dts: qcom: pm8550: Enable BCL sensor present - exact patch-id match at 527ae65 skipped - not checked because qcom-next already contains the change present
12/12 [PATCH 12/12] QCLINUX: defconfig: Enable Qualcomm BCL driver present - all checked added lines are present skipped - not checked because qcom-next already contains the change present

Final Status

overall_status: FAIL
present_commits: 9/12
partial_commits: 1/12
missing_commits: 2/12
topics_checked_for_commits: 3/12
final_summary: PR present in qcom-next/topics: Fail - 2/12 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #892 — checker-log-analyzer

PR: #892
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32849404121

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ 2 warnings (non-blocking style issues)
dt-binding-check Passed
dtb-check Passed
sparse-check Passed
check-uapi-headers Passed
check-patch-compliance 7 commits fail prefix/link checks
tag-check 6 commits missing required subject prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #892 - BCL driver update (Revert old patches and apply new upstream versions)
Target branch: qcom-6.18.y
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32849404121

Checker Result Summary
checkpatch ⚠️ 2 warnings (non-blocking style issues)
dt-binding-check Passed
dtb-check Passed
sparse-check Passed
check-uapi-headers Passed
check-patch-compliance 7 commits fail prefix/link checks
tag-check 6 commits missing required subject prefix

❌ checkpatch

Root cause: Two non-blocking style warnings on commits 59b9e52 and b483aa8.

Failure details:

Commit 59b9e52 ("Revert "FROMLIST: dt-bindings: hwmon: Add qcom,bcl-hwmon yaml bindings""):

WARNING: DT binding docs and includes should be a separate patch.

This is a revert commit that removes a binding file. The warning is a false positive — revert commits inherently touch binding files if the original patch did. No action needed.

Commit b483aa8 ("FROMLIST: hwmon: Add Qualcomm PMIC BCL driver"):

WARNING: struct reg_field should normally be const
#1393: FILE: drivers/hwmon/qcom-bcl-hwmon.c:1315:
+		struct reg_field field = data->reg_fields[i];

This is a legitimate style suggestion. The local variable field is copied from an array and modified, so it cannot be const. This is acceptable — the warning is advisory (not an ERROR).

Fix: Optional. If the upstream patch has this pattern, keep it for consistency. Otherwise, consider refactoring to avoid the copy if trivial.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES \
  --git dc0f4d4280a7..d87a3b269acc

❌ check-patch-compliance

Root cause: 7 commits fail prefix or link validation checks.

Failure details:

6 commits with missing prefix before "Revert":

Commit 924512507f76: Revert "QCLINUX: defconfig: Enable Qualcomm BCL driver"
Commit cdcf395ede9d: Revert "FROMLIST: arm64: dts: qcom: pm8350c: Enable Qualcomm BCL device"
Commit 973d77f628d4: Revert "FROMLIST: arm64: dts: qcom: pm7250b: Enable Qualcomm BCL device"
Commit 333283c9de70: Revert "FROMLIST: hwmon: Add Qualcomm PMIC BCL hardware monitor driver"
Commit 59b9e52f0d6c: Revert "FROMLIST: dt-bindings: hwmon: Add qcom,bcl-hwmon yaml bindings"
Commit d87a3b269acc: QCLINUX: defconfig: Enable Qualcomm BCL driver

Issue: Revert commits must carry a prefix before the word Revert. The checker only accepts FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT: prefixes.
Issue: QCLINUX: prefix is not accepted by check-patch-compliance (known limitation for vendor-only commits).

1 commit with content mismatch:

Commit b483aa820652: FROMLIST: hwmon: Add Qualcomm PMIC BCL driver
Change is different from the one mentioned in Link

→ The patch content differs from the upstream lore link. This may be a legitimate adaptation for the vendor tree or a missing hunk.

Fix:

For revert commits, add a prefix before Revert:

git rebase -i dc0f4d4280a7
# Mark each revert commit as 'edit'
git commit --amend -m "UPSTREAM: Revert \"FROMLIST: ...\""
# or
git commit --amend -m "FROMLIST: Revert \"FROMLIST: ...\""
git rebase --continue

For the QCLINUX: commit (d87a3b2), this is a known checker limitation — vendor-only commits always fail. If this commit has an upstream equivalent, change to FROMLIST: and add a Link: tag. Otherwise, the failure is expected.

For the content mismatch (b483aa8), verify with:

b4 am --single-message -C -l -3 <link-from-commit-body> -o /tmp/out
git format-patch -1 b483aa820652 --stdout > /tmp/pr.patch
diff <(awk '/^diff/,/^--$/' /tmp/pr.patch | grep -E '^[+-][^+-]') \
     <(awk '/^diff/,/^--$/' /tmp/out/*.mbx | grep -E '^[+-][^+-]')

If the diff shows only context shifts or legitimate vendor adaptations, document the changes in the commit message. If there are missing hunks, add them.

Reproduce locally:

cd kernel
bash ../kernel-checkers/check-patch-compliance.sh \
  --base dc0f4d4280a7 --head d87a3b269acc

❌ tag-check

Root cause: 6 commits have subject lines that do not start with a required prefix tag.

Applies because: Target branch qcom-6.18.y is not qcom-next or qcom-next-staging — all commits must carry a subject prefix.

Failure details:

The following commits are missing a prefix before Revert:

924512507f76: Revert "QCLINUX: defconfig: Enable Qualcomm BCL driver"
cdcf395ede9d: Revert "FROMLIST: arm64: dts: qcom: pm8350c: Enable Qualcomm BCL device"
973d77f628d4: Revert "FROMLIST: arm64: dts: qcom: pm7250b: Enable Qualcomm BCL device"
333283c9de70: Revert "FROMLIST: hwmon: Add Qualcomm PMIC BCL hardware monitor driver"
59b9e52f0d6c: Revert "FROMLIST: dt-bindings: hwmon: Add qcom,bcl-hwmon yaml bindings"
d87a3b269acc: QCLINUX: defconfig: Enable Qualcomm BCL driver

Required prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:

Fix:

For revert commits, add a prefix before Revert:

git rebase -i dc0f4d4280a7
# Mark each revert commit as 'edit'
git commit --amend -m "UPSTREAM: Revert \"FROMLIST: ...\""
# Choose the correct prefix based on where the revert itself comes from:
#   - If the revert is posted upstream → FROMLIST:
#   - If the revert is merged upstream → UPSTREAM:
#   - If the revert is vendor-only → QCLINUX:
git rebase --continue

For commit d87a3b2 with QCLINUX: prefix: This prefix is valid for tag-check (unlike check-patch-compliance). However, the commit subject currently starts with QCLINUX:, which is acceptable. This commit passes tag-check — the failure is only in check-patch-compliance.

Corrected tag-check verdict:

  • 5 revert commits fail (missing prefix before Revert)
  • 1 commit (d87a3b2) passes (has QCLINUX: prefix)

Reproduce locally:

git log dc0f4d4280a7..d87a3b269acc --format="%H %s" | while read sha subject; do
  if ! echo "$subject" | grep -qE '^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'; then
    echo "MISSING prefix: $sha $subject"
  fi
done

Verdict

5 blockers must be fixed before merge:

  1. 5 revert commits (9245125, cdcf395, 973d77f, 333283c, 59b9e52) must add a prefix before Revert (e.g., UPSTREAM: Revert "...").
  2. 1 commit (b483aa8) has a content mismatch with its upstream link — verify and document the difference or fix missing hunks.

Non-blocking issues:

  • 2 checkpatch warnings (advisory style suggestions, not errors).
  • 1 QCLINUX: commit (d87a3b2) fails check-patch-compliance due to a known checker limitation for vendor-only commits — this is expected if the commit is truly vendor-only.

Recommendation: Fix the 5 revert commit subjects and verify the content mismatch before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants