generate_boot_bins.sh: add support for efiesp modification - #53
Closed
Ananthu C V (WeepingClown13) wants to merge 1 commit into
Closed
Ananthu C V (WeepingClown13) wants to merge 1 commit into
Ananthu C V (WeepingClown13) wants to merge 1 commit into
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Signed-off-by: Ananthu C V <ananthu.cv@oss.qualcomm.com>
Ananthu C V (WeepingClown13)
force-pushed
the
efiesp
branch
from
July 30, 2026 09:56
f7c5957 to
1909d48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WP meta, efiesp.bin is where kernel, ramfs, and dtb are packed. We need to enable kernelci jobs for WP based devices and since this scripts handles similar logic, this is by far the best place to handle an image generation. The added
efiespcommand currently simply modifies an existing base efiesp (which is an easier option than taking a systemd-boot efi and regenerating everything around it) with the necessary files. It assumes a suitable cmdline in a specific format is present in a specific location. This can be enhanced later if necessary to provide custom cmdline arguments, but it is not a necessity at the moment given there is only one consumer. This will help with the immediate requirement of enabling kernelci jobs for WP meta running devices.EDIT: since this is needed for kernelci, it'll require a new version of docker image released for ci usage.