qdl: support injecting overlays into the flashed rootfs - #86
Open
Matt H (mattface) wants to merge 1 commit into
Open
Matt H (mattface) wants to merge 1 commit into
Matt H (mattface) wants to merge 1 commit into
Conversation
The qdl deploy method has no equivalent of the flasher method's 'overlay' image, so jobs using it cannot add extra files to the image they flash. Instead, when overlays are requested, render a 'to: downloads' deploy action that patches the qdl flash tarball in a docker postprocess. The qdl deploy then flashes the patched tarball via downloads://, and apply-overlay still adds the LAVA test overlay on top. The inputs the fastboot and nfs templates already accept are honoured here too: --overlay URL [PATH], OVERLAY_URL with OVERLAY_PATH, and AUDIO_CLIPS_URL. Jobs without overlays render exactly as before. Signed-off-by: Matt Hart <matthart@qti.qualcomm.com>
Milosz Wasilewski (mwasilew)
requested changes
Aug 12, 2026
Milosz Wasilewski (mwasilew)
left a comment
Milosz Wasilewski (mwasilew)
left a comment
There was a problem hiding this comment.
I think it might be easier to add overlay support in deploy-to-qdl in LAVA. This patch adds a lot of complexity.
| url: '{{ url }}' | ||
| {% if overlay_use_download_headers %} | ||
| headers: | ||
| {{ AUTH_HEADER_NAME }}: {{ AUTH_HEADER_TOKEN }} |
There was a problem hiding this comment.
This should work in theory, but we might expect arifacts stored in different bucket using different tokens. Should the header/token be part of the overlay structure (name,url,dst,header,token_name)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The qdl deploy method has no equivalent of the flasher method's 'overlay' image, so jobs using it cannot add extra files to the image they flash.
Instead, when overlays are requested, render a 'to: downloads' deploy action that patches the qdl flash tarball in a docker postprocess. The qdl deploy then flashes the patched tarball via downloads://, and apply-overlay still adds the LAVA test overlay on top.
The inputs the fastboot and nfs templates already accept are honoured here too: --overlay URL [PATH], OVERLAY_URL with OVERLAY_PATH, and AUDIO_CLIPS_URL. Jobs without overlays render exactly as before.