Meta qcom build provenance - #97
Closed
Matt H (mattface) wants to merge 3 commits into
Closed
Matt H (mattface) wants to merge 3 commits into
Matt H (mattface) wants to merge 3 commits into
Conversation
| @@ -1,4 +1,16 @@ | |||
| build-url: {{BUILD_URL | default('')}} | |||
| build-type: {{BUILD_TYPE | default('')}} | |||
| build-run-id: {{BUILD_RUN_ID | default('')}} | |||
There was a problem hiding this comment.
since we're running this exclusively in github at the moment, what is the difference between build-run-id and gh-workflow-run-id? Aren't these redundant?
Author
There was a problem hiding this comment.
No, they are different inside pull requests, for example compare the gh-workflow-run-id on this job https://lava.infra.foundries.io/scheduler/job/406624/definition#defline23 with the build-url
There was a problem hiding this comment.
They're different because build-id will not be available in the test workflow for PR.
Record the commit under test and the build configuration - machine, distro, kernel, image, test plan and the refs the job was generated from - alongside the existing build and pull request URLs. LAVA indexes the metadata and filters on it, so these become keys jobs can be selected by. Every new key defaults to empty, so callers that do not set them render as before. Signed-off-by: Matt Hart <matthart@qti.qualcomm.com>
meta-qcom-3rdparty and the qcom-distro variant of meta-qcom each kept a byte-identical copy of the metadata template, so a key added to one silently skipped the others. meta-qcom-distro already symlinks its copy; do the same for the remaining two. meta-qcom-3rdparty jobs now render the provenance keys, empty until its own workflow sets them. flit dereferences symlinks when building the wheel, so installs are unaffected. Signed-off-by: Matt Hart <matthart@qti.qualcomm.com>
The metadata templates render the commit under test and the build configuration, but the action never set the variables behind them, so they came out empty for every caller. Fill them in. Only the source commit, its branch and the kind of build need new inputs: the machine, distro, kernel, image, test plan and both revisions are already known to the action. Signed-off-by: Matt Hart <matthart@qti.qualcomm.com>
Matt H (mattface)
force-pushed
the
meta-qcom-build-provenance
branch
from
September 9, 2026 17:10
8a78e02 to
3e32408
Compare
Matt H (mattface)
marked this pull request as draft
September 9, 2026 21:17
Author
|
scrapping this because functionality is replaced by EXTRA_METADATA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of a series of metadata expansions to meta-qcom and other projects that use lava-test-plans