tflite: always fetch neon2sse instead of gating per-arch - #31
Merged
Koen Kooi (koenkooi) merged 1 commit intoSep 10, 2026
Merged
Koen Kooi (koenkooi) merged 1 commit into
Koen Kooi (koenkooi) merged 1 commit into
Conversation
SRC_URI/SRCREV_FORMAT only pulled in the NEON-to-SSE translation shim on x86/x86-64 via :class-target overrides, and do_configure guarded the matching symlink with a directory-exists check. That means every new target arch that could use the shim needs its own override added. Fetch it unconditionally instead: it's a small git repo and harmless to fetch on arches that don't use it, matching the same fix already applied to the litert recipe. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:class-target:x86/:class-target:x86-64SRC_URI/SRCREV_FORMAToverrides, withdo_configureguarding the symlink on a directory-exists check. Every new target arch that needs the shim would require yet another override — the same whack-a-mole pattern just fixed for thelitertrecipe in litert: add x86_64 support #29.SRC_URI/SRCREV_FORMAT, drop the arch-gated overrides, and simplify thedo_configure:prepend()symlink to an unconditionalln -sfmatching the other third-party symlinks in that function.Test plan
kas-containerbuild for both qemuarm64 and qemux86-64 (this change was validated together with the analogous litert fix in litert: add x86_64 support #29's testing).Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com