Skip to content

qcom-xfce-demo-image: drop IMAGE_BASENAME export - #409

Merged
Dmitry Baryshkov (lumag) merged 1 commit into
qualcomm-linux:mainfrom
quaresmajose:world
Aug 6, 2026
Merged

qcom-xfce-demo-image: drop IMAGE_BASENAME export#409
Dmitry Baryshkov (lumag) merged 1 commit into
qualcomm-linux:mainfrom
quaresmajose:world

Conversation

@quaresmajose

@quaresmajose Jose Quaresma (quaresmajose) commented Aug 3, 2026

Copy link
Copy Markdown
Member

This is not necessary and only has cosmetic effects, capitalizing some letters.

@quaresmajose

Jose Quaresma (quaresmajose) commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

Discovered in qualcomm-linux/meta-qcom#2199 which triggered https://github.com/qualcomm-linux/meta-qcom/actions/runs/30820261079/job/91718174335

2026-08-03 14:37:36 - ERROR    - ERROR: Nothing PROVIDES 'Qualcomm-XFCE-demo-image'
2026-08-03 14:37:36 - ERROR    - ERROR: Required build target 'qcom-xfce-demo-image' has no buildable providers.
2026-08-03 14:37:36 - ERROR    - Missing or unbuildable dependency chain was: ['qcom-xfce-demo-image', 'Qualcomm-XFCE-demo-image']
2026-08-03 14:37:37 - INFO     - 
2026-08-03 14:37:37 - INFO     - Summary: There were 2 ERROR messages, returning a non-zero exit code.
2026-08-03 14:37:37 - ERROR    - Command "/work/build$ /work/bitbake/bin/bitbake -c build world" failed:
ERROR: Nothing PROVIDES 'Qualcomm-XFCE-demo-image'
ERROR: Required build target 'qcom-xfce-demo-image' has no buildable providers.
Missing or unbuildable dependency chain was: ['qcom-xfce-demo-image', 'Qualcomm-XFCE-demo-image']
2026-08-03 14:37:37 - ERROR    - Command "/work/bitbake/bin/bitbake -c build world" failed with error 1

@lumag

Dmitry Baryshkov (lumag) commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

According to the discovered build failure, it fixes a real issue rather than a cosmetics change.

@quaresmajose

Jose Quaresma (quaresmajose) commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Yes, that's true, I modified the commit.

This was referenced Aug 4, 2026
Closed
Closed
lumag
Dmitry Baryshkov (lumag) requested changes Aug 4, 2026
View reviewed changes

@lumag Dmitry Baryshkov (lumag) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still can't agree with "it's not necessary" part.

@quaresmajose

Jose Quaresma (quaresmajose) commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

I still can't agree with "it's not necessary" part.

Can you explain why you see this as necessary?

@lumag

Dmitry Baryshkov (lumag) commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

I still can't agree with "it's not necessary" part.

Can you explain why you see this as necessary?

Because otherwise BB world fails

@quaresmajose
qcom-xfce-demo-image: drop IMAGE_BASENAME export
3ac820f 
Redefine the IMAGE_BASENAME it's basically a cosmetic change capitalizing
some letters. The export of IMAGE_BASENAME will reset the PROVIDES,
consequently causing the 'bitbake world' to fail:

| ERROR: Nothing PROVIDES 'Qualcomm-XFCE-demo-image'
| ERROR: Required build target 'qcom-xfce-demo-image' has no buildable providers.
| Missing or unbuildable dependency chain was: ['qcom-xfce-demo-image', 'Qualcomm-XFCE-demo-image']

Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
@quaresmajose

Jose Quaresma (quaresmajose) commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

I still can't agree with "it's not necessary" part.

Can you explain why you see this as necessary?

Because otherwise BB world fails

I think we're facing a communication problem, and I'm not expressing myself in the best way.
Updated the commit message.

@lumag
Dmitry Baryshkov (lumag) merged commit 51901d6 into qualcomm-linux:main Aug 6, 2026
277 of 280 checks passed
@quic-yocto-ci

quic-yocto-ci commented Aug 6, 2026

Copy link
Copy Markdown

Successfully created backport PR for wrynose:

@quic-yocto-ci quic-yocto-ci mentioned this pull request Aug 6, 2026
Merged
Ricardo Salveti (ricardosalveti) added a commit that referenced this pull request Sep 1, 2026
@ricardosalveti
[Backport wrynose] qcom-xfce-demo-image: drop IMAGE_BASENAME export (#…
71c893d 
…413)

# Description
Backport of #409 to `wrynose`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lumag Dmitry Baryshkov (lumag) lumag approved these changes
@anujm1 Anuj Mittal (anujm1) anujm1 approved these changes
@vkraleti Viswanath Kraleti (vkraleti) Awaiting requested review from vkraleti vkraleti is a code owner
@ricardosalveti Ricardo Salveti (ricardosalveti) Awaiting requested review from ricardosalveti ricardosalveti is a code owner
@ndechesne Nicolas Dechesne (ndechesne) Awaiting requested review from ndechesne ndechesne is a code owner
@koenkooi Koen Kooi (koenkooi) Awaiting requested review from koenkooi koenkooi is a code owner

Assignees

No one assigned

Labels

backport wrynose

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@quaresmajose @lumag @quic-yocto-ci @anujm1