crash: Fix cross compilation for 32-bit arm - #411
Jose Quaresma (quaresmajose) wants to merge 1 commit into
Conversation
The upstream crash Makefile CONF_TARGET_ARCH mapping (used when
CROSS_COMPILE is set) enumerates most of OE supported arches
but omits 32-bit arm. Building with CROSS_COMPILE=arm-*
therefore aborts at Makefile parse time:
Makefile:75: *** The current Arch(arm) does not support cross compilation. Stop.
ARM is already a valid crash target (defs.h/configure.c), so add a patch
mapping the normalized "arm" arch to CONF_TARGET_ARCH=ARM like every
other supported arch.
Verified by cross building crash for qemuarm (arm-yoe-linux-gnueabi-):
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
Cc: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Backport from meta-oe 63a529202
Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
d54d006 to
8e05cf0
Compare
|
Can we merge this? The qcom-armv8a/qcom-distro-catchall fails is unreated to this change and it is due to qualcomm-linux/meta-qcom#2871 |
|
How didn't we catch this issue before bumping meta-oe? |
Good question, but I don't have the answer. This problem appeared to me when proposing the world build of meta-qcom-distro in qualcomm-linux/meta-qcom#2199. |
It is happening with other meta-qcom-distro PRs as well, so not really related to world build. |
world for armv7 was removed in meta-qcom (by mistake, as catchall is not supported for it) but not from meta-qcom-distro, so that is why we are only seeing this failure here. Moved your patch to meta-qcom since the recipe that is bringing the crash dependency is initramfs-test-full-image, available in meta-qcom (but only used when meta-oe is available). |
I had forgotten about that change to reduce the number of world builds. Closed in favor of qualcomm-linux/meta-qcom#2878 |
Re-enable world build for qcom-armv7 (which got disabled by mistake as part of bf4b626), and bring the crash related fix from qualcomm-linux/meta-qcom-distro#411 as initramfs-test-full-image depends on it (when meta-oe is available).
3 participants
The upstream crash Makefile CONF_TARGET_ARCH mapping (used when CROSS_COMPILE is set) enumerates most of OE supported arches but omits 32-bit arm. Building with CROSS_COMPILE=arm-* therefore aborts at Makefile parse time:
ARM is already a valid crash target (defs.h/configure.c), so add a patch mapping the normalized "arm" arch to CONF_TARGET_ARCH=ARM like every other supported arch.
Verified by cross building crash for qemuarm (arm-yoe-linux-gnueabi-):
Backport from meta-oe 63a529202