-
Notifications
You must be signed in to change notification settings - Fork 365
Switch to KVM hypervisor on Rb3Gen2-Core-Kit and QCM6490-IDP #2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
81a6516
6b291ff
8a3ce07
d45717e
8bced9a
1a71920
36f577e
8eb083a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
| require conf/machine/include/qcom-qcs6490.inc | ||
|
|
||
| # NOTE: TPM hardware is only present on rb3gen2-industrial kit | ||
| MACHINE_FEATURES += "efi m2connector pci tpm2 phone" | ||
| MACHINE_FEATURES += "efi kvm m2connector pci tpm2 phone" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will break capsule update for rb3gen2 as it is still using xbl_config.elf (the kvm logic is only in qcomflash).
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Discussed this case with the Target team. ishnajain (@ishnajain-qcom) uchitroj-qcom agreed to provide an updated bootbins/Meta build where KVM's config is going to be copied as default xbl_config.elf. This switch can happen only after HLOS also switch i.e. post merging this PR.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Merging this PR will break capsule update, so the firmware update should go along with this PR. Are we expecting a new boot firmware to be provided before 2.1? Otherwise we should just change the capsule update logic to handle other xbl_configs (as it will be needed for gunyah anyway, since capsule should work with both).
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #3165 is to rename XBL_Config.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can merge based on #3045 as well, then we can include the boot firmware changes that would switch the default xbl_config.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #3045 is now merged.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rebased. |
||
|
|
||
| KERNEL_DEVICETREE ?= " \ | ||
| qcom/qcs6490-rb3gen2.dtb \ | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.