userspace-resource-manager: Update to v0.4.9 - #3026
Ricardo Salveti (ricardosalveti) merged 1 commit into
Conversation
Test Results 119 files ± 0 715 suites ±0 8h 57m 31s ⏱️ - 7h 9m 41s For more details on these failures, see this check. Results for commit 0e6c2b5. ± Comparison against base commit 7659417. This pull request removes 9 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
218ae37 to
e07c6fe
Compare
Ricardo Salveti (ricardosalveti)
left a comment
There was a problem hiding this comment.
- Test configs moved to /usr/share and /var/lib, instead of /etc/urm/tests
This breaks SOTA, you should not install & package content in /var.
|
Hi Ricardo Salveti (@ricardosalveti) The files installed in /var/lib are test assets used to simulate sysfs nodes and are only installed when the optional test package is explicitly installed by the user. They are not runtime-generated state. However, if the requirement is to not maintain any files in /var/lib we can potentially move them to /usr/share |
Yes, please |
Yes, anything that can be installed should not land in /var, move to /usr/share. |
e07c6fe to
9668678
Compare
9668678 to
cd32566
Compare
CHANGES in v0.4.9 - URM Executable moved to /usr/sbin - post-boot configs moved from /etc/urm/initscripts to /usr/libexec/initscripts - Test configs moved to /usr/share/urm/tests, instead of /etc/urm/tests - Additional Configs for Seraph - Added the retuneSignal API, to extend duration of existing signal configurations - Removed the BUILD_EXTENSIONS CMake flag, to ensure the extensions package is always generated alongside URM, users retain the flexibility to install / remove the extensions package according to their requirements. - Update project licensing from BSD-3-Clause-Clear to BSD-3-Clause - Updated URM test framework, so that the test nodes are correctly placed in a rw directory prior to testing. This is achieved by using the mktemp system call in the test runner and passing the path returned by the system call to the URM test binaries UrmIntegrationTests and UrmComponentTests, appropriate CLI handling options have been added to the above binaries. Signed-off-by: Kartik Nema <kartnema@qti.qualcomm.com>
cd32566 to
0e6c2b5
Compare
|
Hi Ricardo Salveti (@ricardosalveti) kindly request to review the PR |
|
KNown failures. |
f312b47
into
qualcomm-linux:master
|
Successfully created backport PR for |
# Description Backport of #3026 to `wrynose`.
userspace-resource-manager: Update to v0.4.9
CHANGES in v0.4.9
package is always generated alongside URM, users retain the flexibility
to install / remove the extensions package according to their requirements.
a rw directory prior to testing. This is achieved by using the mktemp system
call in the test runner and passing the path returned by the system call to
the URM test binaries UrmIntegrationTests and UrmComponentTests, appropriate
CLI handling options have been added to the above binaries.