meta-qcom: add RTSS mailbox DLKM/UMD recipes (phase 1) - #3084
sargarram7 wants to merge 3 commits into
Conversation
|
Check-layer is failing. |
7b0844d to
09b4afd
Compare
|
Squash the changes, you don't need multiple patches fixing the same recipe here. And it is still failing. |
09b4afd to
92922bc
Compare
Ricardo Salveti (@ricardosalveti) thank you for capturing this , check layer issue is fixed |
Dmitry Baryshkov (lumag)
left a comment
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Also. PLEASE, STOP MOVING THE TAGS.
Once tagged, it should stay as is. You can't push a new tag just because. If you changed the code in the repo, it's a new tag.
Test Results 30 files - 51 30 suites - 396 1h 41m 0s ⏱️ - 5h 45m 19s For more details on these failures, see this check. Results for commit e9db04c. ± Comparison against base commit 1efd355. This pull request removes 160 tests.♻️ This comment has been updated with latest results. |
|
Moving to draft until the required kernel changes are in place. |
| LICENSE = "GPL-2.0-only" | ||
| LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e" | ||
|
|
||
| SRC_URI = "git://github.com/qualcomm-linux/rtss-mailbox-kmd.git;branch=rtss-mailbox-kernel.le.0.0;protocol=https;tag=v${PV}" |
| LICENSE = "GPL-2.0-only" | ||
| LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e" | ||
|
|
||
| SRC_URI = "git://github.com/qualcomm-linux/rtss-mailbox-kmd.git;branch=rtss-mailbox-kernel.le.0.0;protocol=https;tag=v${PV}" |
There was a problem hiding this comment.
Is /dev/rtssmb meant to be root only?
There was a problem hiding this comment.
we can have as of now root, aligned with 1.x .
selinux module rules patch will come in next PR separately.
There was a problem hiding this comment.
What is the expected usage model? Several daemons accessing it? What about the user apps? Can the devices be restricted to a certain group?
There was a problem hiding this comment.
plan - DAC + MAC support enablement
92922bc to
e9db04c
Compare
There was a problem hiding this comment.
Ricardo Salveti (@ricardosalveti) , Dmitry Baryshkov (@lumag) thank you for feedback, could you please take look
Dmitry Baryshkov (lumag)
left a comment
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Provides the userspace API, OTA/update tooling, and debug utilities
You haven't read CONTRIBUTING.md, have you?
7964913 to
322fcb0
Compare
updated commit message |
|
hi Dmitry Baryshkov (@lumag), Ricardo Salveti (@ricardosalveti), |
1c46326 to
452a6f1
Compare
| SRC_URI = "git://github.com/qualcomm-linux/rtss-mailbox-kmd.git;branch=rtss-mailbox-kernel.le.0.0;protocol=https;tag=v${PV}" | ||
| SRCREV = "9ce7c2f1ad860beb86e922e62b14fdcd178e129f" | ||
|
|
||
| COMPATIBLE_MACHINE = "qcs9100-ride-sx|qcs8300-ride-sx|iq-9075-evk|iq-8275-evk" |
There was a problem hiding this comment.
Use the SoC overrides instead, like COMPATIBLE_MACHINE = "qcs8300|qcs9100".
Also, this will also be included by the headers recipe, and headers is probably generic and not machine specific.
Add the qcom-rtss-mailbox-dlkm recipe to build the RTSS mailbox kernel driver (DLKM), exposing the IPC path between APSS and RTSS via /dev/rtssmb. Also add qcom-rtss-mailbox-uapi-headers to package the ioctl/struct UAPI (rtss_mailbox_uapi.h) standalone, so userspace can build against it without depending on the kernel module recipe. Both recipes share SRC_URI/SRCREV/LICENSE via qcom-rtss-mailbox-module-common.inc, since they come from the same upstream tree (rtss-mailbox-kmd). NOTICE: this driver is still being upstreamed and its uAPI (rtss_mailbox_uapi.h) is not yet frozen and may change before upstream acceptance -- see rtss-mailbox-kmd's README for details. Signed-off-by: Ram Sargar <rsargar@qti.qualcomm.com>
Add the qcom-rtss-mailbox-umd recipe to build the userspace umd component. Signed-off-by: Ram Sargar <rsargar@qti.qualcomm.com>
Add qcom-rtss-mailbox-dlkm, qcom-rtss-mailbox-umd, and
qcom-rtss-mailbox-umd-utils via MACHINE_EXTRA_RRECOMMENDS in
qcom-qcs8300.inc and qcom-qcs9100.inc instead, alongside the
existing packagegroup-qcom-boot-additional entry. This mechanism
feeds packagegroup-machine-base, which sets
PACKAGE_ARCH = "${MACHINE_ARCH}" and is machine-specific,
so it carries no allarch signature.
Signed-off-by: Ram Sargar <rsargar@qti.qualcomm.com>
452a6f1 to
f77a92b
Compare
5 participants
Target milestone: QLI-2.1
Background
Customer use cases driving this - CAN communication, RTSS-to-HLOS userspace communication, OTA updates, and on-device programming/flashing. all need working IPC path between the application processor and RTSS. That path doesn't exist upstream today. This is phase 1 of bringing the downstream, out-of-tree RTSS mailbox stack into the open-source tree to support these IPC use cases going forward.
Tracking issue:
#3085
This PR dependency
Related PRs
This is part of a set of PRs bringing the RTSS mailbox stack into the open-source tree:
qcom,rtss-mailbox):RTSS interface enablement is handled using a staging DTBO overlay to carry the rtss mailbox node, both bootup and DTBO patching with it applied have been verified on target.
Testing