Skip to content

[Backport wrynose] firmware-qcom-boot-shikra: update tag 00072 -> 00078 - #3145

Closed
Viswanath Kraleti (vkraleti) wants to merge 1 commit into
wrynosefrom
backport/3139-to-wrynose
Closed

[Backport wrynose] firmware-qcom-boot-shikra: update tag 00072 -> 00078#3145
Viswanath Kraleti (vkraleti) wants to merge 1 commit into
wrynosefrom
backport/3139-to-wrynose

Conversation

@vkraleti

@vkraleti Viswanath Kraleti (vkraleti) commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Description

Backport of #3139 to wrynose.

@ArunSahu418 @github-actions
firmware-qcom-boot-shikra: update tag 00072 -> 00078
28e16aa 
Update Shikra bootbinaries to build 00078.

This boot firmware update includes UEFI changes to support efivar.

Signed-off-by: Arun Sahu <arunsahu@qti.qualcomm.com>
(cherry picked from commit 97223d6)
@lumag

Dmitry Baryshkov (lumag) commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Viswanath Kraleti (@vkraleti) you haven't even checked what you have comitted. Please stop.
sbanerjeeqc ^^

@vkraleti

Viswanath Kraleti (vkraleti) commented Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

May I know what is wrong here?

There are network glitches and backport failed. Hence created manually. See #3139 (comment)

image

@lumag

Dmitry Baryshkov (lumag) commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

May I know what is wrong here?

The PR promises to upgrade the firmware. However. Does it touch the old version? No. It just adds new version of the recipe.

@vkraleti

Viswanath Kraleti (vkraleti) commented Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

May I know what is wrong here?

The PR promises to upgrade the firmware. However. Does it touch the old version? No. It just adds new version of the recipe.

It is not my fault. They way auto propagation is handling backports has issues. This happened in the past as well, when #2824 was propagated to wrynose as #2875.

Closed
@lumag

Dmitry Baryshkov (lumag) commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

May I know what is wrong here?

The PR promises to upgrade the firmware. However. Does it touch the old version? No. It just adds new version of the recipe.

It is not my fault. They way auto propagation is handling backports has issues. This happened in the past as well, when #2824 was propagated to wrynose as #2875.

In this case it's not the 'autopropagation'. It's reviewing the commits before you push them out.

@vkraleti

Viswanath Kraleti (vkraleti) commented Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

I just did a git push from a branch that is already created by automation. The issue seems from commits that delete files which no doesn't exist in the target branch. If this PR had been created after merging #3140, there would not have been a problem. Since it was created before, instead of reporting a conflict, the deleted file was silently omitted during the merge and branch got created, and the resulting commits ended up containing only the new file additions.

@lumag
Dmitry Baryshkov (lumag) deleted the backport/3139-to-wrynose branch September 13, 2026 16:56
@vkraleti

Viswanath Kraleti (vkraleti) commented Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

BTW #3146 created by backport automation also left the stale file behind. Such changes just need an extra pair of eyes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardosalveti Ricardo Salveti (ricardosalveti) Awaiting requested review from ricardosalveti ricardosalveti is a code owner
@ndechesne Nicolas Dechesne (ndechesne) Awaiting requested review from ndechesne ndechesne is a code owner
@lumag Dmitry Baryshkov (lumag) Awaiting requested review from lumag lumag is a code owner
@anujm1 Anuj Mittal (anujm1) Awaiting requested review from anujm1 anujm1 is a code owner
@koenkooi Koen Kooi (koenkooi) Awaiting requested review from koenkooi koenkooi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

qli-2.1 pull-request freeze

Development

Successfully merging this pull request may close these issues.

3 participants

@vkraleti @lumag @ArunSahu418