fit-dtb-compatible: fix missing tc956x overlay entries kodiak - #3159
Eshitha oyyavuru (kppeoyyavuru) wants to merge 1 commit into
Conversation
Dmitry Baryshkov (lumag)
left a comment
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
knaveen-qc sbanerjeeqc From this PR it looks like TC956x wasn't tested by the developers who added support for it in QLI.
| "lemans-evk lemans-evk-camera-csi1-imx577 lemans-el2 lemans-evk-sd-card" | ||
| FIT_DTB_COMPATIBLE[qcom_qcs9075-iot-staging] = \ | ||
| "lemans-evk lemans-evk-camera-csi1-imx577 lemans-staging lemans-el2 lemans-evk-sd-card" | ||
| "lemans-evk lemans-evk-camera-csi1-imx577 lemans-evk-ifp-mezzanine lemans-staging lemans-evk-staging lemans-el2 lemans-evk-sd-card" |
There was a problem hiding this comment.
What is lemans-evk-ifp-mezzanine and why is it not a part of qcom_qcs9075-iot? Why are you changing only the KVM list of overlays and completely miss the Gunyah list on the next line?
| "monaco-evk monaco-evk-camera-imx577 monaco-el2 monaco-evk-emmc" | ||
| FIT_DTB_COMPATIBLE[qcom_qcs8275-iot-staging] = \ | ||
| "monaco-evk monaco-evk-camera-imx577 monaco-staging monaco-el2 monaco-evk-sd-card" | ||
| "monaco-evk monaco-evk-camera-imx577 monaco-evk-ifp-mezzanine monaco-el2 monaco-staging monaco-evk-staging" |
There was a problem hiding this comment.
Same questions, but also, why are you removing sd-card overlay?
There was a problem hiding this comment.
Thanks for the detailed review and for raising these questions.
After re-investigating the issue, I realized this was actually a false positive from the test setup rather than a problem with the existing Lemans/Monaco FIT configuration.
The board used during validation did not have the expected CDT flashed. Once the correct CDT was flashed and the test was repeated, both Lemans and Monaco behaved as expected without any of the changes proposed in this PR.
With the correct CDT in place+ efivar, the required overlays are loaded properly and the functionality works as expected. As a result, the Lemans and Monaco changes are not required.
Sorry for the noise here. I'll drop those changes and keep only the RB3 Gen2 fix, which addresses a separate issue.
901cdca to
a16a788
Compare
…staging FIT_DTB_COMPATIBLE[qcom_qcs5430-iot-subtype2-staging] and [qcom_qcs6490-iot-subtype2-staging] only pulled in kodiak-staging. qcs6490-rb3gen2-staging - the overlay that provides the phy-reset-gpios property the tc956x PCIe Ethernet driver needs - was never included in either combo. Without it, phy-reset-gpios is absent from the resolved device tree, the tc956x driver probe fails with -ENOENT, and both Ethernet interfaces are missing on RB3 Gen2 whenever staging is requested on subtype2 (vision-mezzanine) boards. Add qcs6490-rb3gen2-staging to both combos, ordered after kodiak-staging so its phy-reset-gpios property name takes precedence over kodiak-staging's. Signed-off-by: Eshitha Oyyavuru <eoyyavur@qti.qualcomm.com>
a16a788 to
1f1877d
Compare
Eshitha oyyavuru (kppeoyyavuru)
changed the title
| "qcs6490-rb3gen2 qcs6490-rb3gen2-vision-mezzanine kodiak-staging qcs6490-rb3gen2-staging" | ||
| FIT_DTB_COMPATIBLE[qcom_qcs6490-iot-subtype2-staging] = \ | ||
| "qcs6490-rb3gen2 qcs6490-rb3gen2-vision-mezzanine kodiak-staging" | ||
| "qcs6490-rb3gen2 qcs6490-rb3gen2-vision-mezzanine kodiak-staging qcs6490-rb3gen2-staging" |
There was a problem hiding this comment.
We should change all the rb3gen2 entries which are using kodiak-staging.
| FIT_DTB_COMPATIBLE[qcom_qcs5430-iot-subtype2-camx-staging] = \ | ||
| "qcs6490-rb3gen2 qcs5430-fps-camx kodiak-staging" | ||
| FIT_DTB_COMPATIBLE[qcom_qcs6490-iot-camx-staging] = \ | ||
| "qcs6490-rb3gen2 qcs6490-rb3gen2-vision-mezzanine-camx kodiak-staging" |
There was a problem hiding this comment.
Are these missing too?
Test Results 119 files ± 0 715 suites ±0 9h 23m 50s ⏱️ - 3m 7s For more details on these failures, see this check. Results for commit 1f1877d. ± Comparison against base commit c672971. |
3 participants
One FIT_DTB_COMPATIBLE configuration was missing a board-specific staging overlay that provides the phy-reset-gpios property required by tc956x-based Ethernet ports, causing driver probe failures and missing Ethernet interfaces.
kodiak (qcs5430/qcs6490, RB3 Gen2): qcs6490-rb3gen2-staging was missing from both subtype2-staging configurations.
Without this overlay, phy-reset-gpios is absent from the resolved device tree and tc956x Ethernet probe fails with:
Add the missing qcs6490-rb3gen2-staging overlay to the affected FIT_DTB_COMPATIBLE configurations so the required Ethernet PHY reset properties are applied whenever the corresponding staging configuration is selected.
Internal CR 4677165.