Skip to content

qps615-dlkm: fix devtool build directory and package version #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paddy-chiu wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −0
Open

qps615-dlkm: fix devtool build directory and package version #3163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions recipes-kernel/qps615-module/qps615-dlkm_git.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,29 @@ SRCREV = "2cbd7b9ddf2318d58044dcbd57dc187dfca55034"

SRC_URI = "git://github.com/qualcomm-linux/TC9564_Host_Driver.git;protocol=https;branch=qcom"

QPS615_ORIGINAL_SRC_URI := "${SRC_URI}"

def qps615_pkgv_suffix(d):
import bb.fetch

data = d.createCopy()
data.setVar("SRC_URI", d.getVar("QPS615_ORIGINAL_SRC_URI"))
return bb.fetch.get_pkgv_string(data)

PV = "6.0.3+git"

# externalsrc removes the Git URI from SRC_URI, so package_setup_pkgv() cannot
# append the normal SCM revision suffix. Reuse BitBake's own revision formatter
# so devtool package versions match versions from the regular fetch/build path.
QPS615_PKGREV = "${@qps615_pkgv_suffix(d)}"
PKGV = "${@d.getVar('PV') + d.getVar('QPS615_PKGREV') if d.getVar('EXTERNALSRC') else d.getVar('PV')}"

@ricardosalveti Ricardo Salveti (ricardosalveti) Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above changes should be separated on a different commit.

Also, is this really qps615-dlkm specific? I think this is just an oe-core issue.

B = "${S}/drivers/net/ethernet/toshiba/tc956x"

# devtool/externalsrc replaces B with a separate work directory unless the
# out-of-tree build directory is explicitly provided.
EXTERNALSRC_BUILD = "${EXTERNALSRC}/drivers/net/ethernet/toshiba/tc956x"

@ricardosalveti Ricardo Salveti (ricardosalveti) Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is ok.


# The original Makefile uses an "ifeq ($(pf), 1)" check to pick the default config.
# Therefore, pf=1 needs to be set while compiling for non-SRIOV VF config.
EXTRA_OEMAKE += "KCFLAGS='-DTC956X -DCONFIG_TC956X_PLATFORM_SUPPORT -DTC956X_SRIOV_PF' pf=1"
Expand Down