Skip to content

update boot firmware to 00143 - #3165

Open
ishnajain (ishnajain-qcom) wants to merge 4 commits into
qualcomm-linux:masterfrom
ishnajain-qcom:bootbins_kvm
Open

ishnajain (ishnajain-qcom) wants to merge 4 commits into
qualcomm-linux:masterfrom
ishnajain-qcom:bootbins_kvm

Conversation

@ishnajain-qcom

Copy link
Copy Markdown
Member

This PR updates the QCS615,QCS9100, QCS8300 and QCS6490 boot firmware to tag 00143 and adapts to a new upstream delivery format where KVM is now the default XBL configuration (xbl_config.elf), and Gunyah is explicitly renamed (xbl_config_gunyah.elf)."

The upstream delivery format for this release changes the naming
convention for the XBL configuration binaries. The KVM configuration
is now provided as the default xbl_config.elf, while the Gunyah
configuration is explicitly renamed to xbl_config_gunyah.elf.

Signed-off-by: Ishna Jain <ishnjain@qti.qualcomm.com>
The upstream delivery format for this release changes the naming
convention for the XBL configuration binaries. The KVM configuration
is now provided as the default xbl_config.elf, while the Gunyah
configuration is explicitly renamed to xbl_config_gunyah.elf.

Signed-off-by: Ishna Jain <ishnjain@qti.qualcomm.com>
The upstream delivery format for this release changes the naming
convention for the XBL configuration binaries. The KVM configuration
is now provided as the default xbl_config.elf, while the Gunyah
configuration is explicitly renamed to xbl_config_gunyah.elf.

Signed-off-by: Ishna Jain <ishnjain@qti.qualcomm.com>
The upstream delivery format for this release changes the naming
convention for the XBL configuration binaries. The KVM configuration
is now provided as the default xbl_config.elf, while the Gunyah
configuration is explicitly renamed to xbl_config_gunyah.elf.

Signed-off-by: Ishna Jain <ishnjain@qti.qualcomm.com>
@github-actions

Copy link
Copy Markdown

Test run workflow

Test jobs for commit d706152

qcom-distro
Pass: 9 | Fail: 3 | Total: 12
qcom-distro_linux-qcom-6.18
Pass: 6 | Fail: 2 | Total: 8
nodistro
Pass: 8 | Fail: 2 | Total: 10

@test-reporting-app

Copy link
Copy Markdown

Test Results

 30 files   -    38   30 suites   - 289   2h 47m 0s ⏱️ - 3h 0m 43s
 15 tests  -   138    9 ✅  -   134  0 💤 ± 0   6 ❌  -  4 
261 runs   - 1 842  239 ✅  - 1 819  0 💤  - 33  22 ❌ +10 

For more details on these failures, see this check.

Results for commit d706152. ± Comparison against base commit 0397e37.

This pull request removes 140 and adds 2 tests. Note that renamed tests count towards both.
0_AudioRecord_Config01 ‑ AudioRecord_Config01
0_BT_FW_KMD_Service ‑ BT_FW_KMD_Service
0_GStreamer_Video_Encode_h264_480p ‑ GStreamer_Video_Encode_h264_480p
0_Libcamera_cam ‑ Libcamera_cam
0_Weston_Runtime_Preflight ‑ Weston_Runtime_Preflight
0_hotplug ‑ hotplug
10_AudioRecord ‑ AudioRecord
10_Docker_Kernel_Config ‑ Docker_Kernel_Config
10_Kubernetes_Kernel_Config ‑ Kubernetes_Kernel_Config
11_DSP_AudioPD ‑ DSP_AudioPD
…
lava ‑ boot-qdl-retry
lava ‑ flash-qdl

@vkraleti

Copy link
Copy Markdown
Contributor

ishnajain (@ishnajain-qcom) you also need to swap QCOM_XBL_CONFIG selection in qcom-common.inc.

@vkraleti

Copy link
Copy Markdown
Contributor

ishnajain (@ishnajain-qcom) Just now noticed that the commit 7c9711d is adding an unwanted QCS615_bootbinaries_00143.zip file. You must drop it.

@ricardosalveti

Copy link
Copy Markdown
Contributor

ishnajain (ishnajain (@ishnajain-qcom)) Just now noticed that the commit 7c9711d is adding an unwanted QCS615_bootbinaries_00143.zip file. You must drop it.

Why unwanted?

@ricardosalveti

Copy link
Copy Markdown
Contributor

I think renaming xbl_config, and changing the hypervisor as a side effect, is a bad change, as it will cause unexpected behavior for users consuming this update (suddenly the default xbl_config will switch from gunyah to kvm).

Also, we can only do this rename for all targets, so it needs to be an all or nothing. It would be terribly confusing to have kvm enable via xbl_config for some but gunyah for others, using the same file name.

We should probably just stick with different files, and have a variable defining the default one to be used as part of the machine conf.

@vkraleti

Copy link
Copy Markdown
Contributor

ishnajain (ishnajain (ishnajain (@ishnajain-qcom))) Just now noticed that the commit 7c9711d is adding an unwanted QCS615_bootbinaries_00143.zip file. You must drop it.

Why unwanted?

There is no need check-in binary .zips into the layer, they are supposed to be fetched from a remote location.

image

@lumag Dmitry Baryshkov (lumag) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? What is wrong with the current naming scheme? If you want to be explicit, don't add "default" config. Let's have two separate entries, xbl_config_kvm.mbn and xbl_config_gunyah.mbn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants