Diag log - #46
Draft
pawarai123 wants to merge 4 commits into
Draft
Diag log#46pawarai123 wants to merge 4 commits into
pawarai123 wants to merge 4 commits into
Conversation
| CFG_QCOM_RPMH_CLIENT ?= n | ||
| CFG_QCOM_PAS_PTA ?= n | ||
|
|
||
| CFG_QCOM_DIAG_LOG ?= $(CFG_TEE_CORE_DEBUG) |
Contributor
There was a problem hiding this comment.
Functional bug: enabling diag log on a platform that lacks TCSR_BOOT_MISC_DETECT breaks the debug build.
This enables CFG_QCOM_DIAG_LOG (defaulting to CFG_TEE_CORE_DEBUG), which compiles diag_log.c. That file uses TCSR_BOOT_MISC_DETECT at file scope (in register_phys_mem_pgdir(...)), but neither bruin/shikra/target_config.h nor bruin/arch_config.h defines it (only bobcat/hoya/cacao do). Debug builds for shikra fail to compile. Same issue for nord (wildcat/nord/target.mk, no define in wildcat/arch_config.h or wildcat/nord/target_config.h).
There was a problem hiding this comment.
Harshal/Pawan, please help to address this comment.
Is this same issue where we need to configure IMEM to enable TZ log?
Sumit Garg (b49020)
force-pushed
the
qcom-next
branch
2 times, most recently
from
September 7, 2026 07:43
1a117cb to
dab3efd
Compare
pawarai123
force-pushed
the
diag-log
branch
from
September 15, 2026 16:41
4f0ce7d to
ad61c7f
Compare
Add the platform configuration required by the diagnostic ring buffer on the Wildcat architecture, including the buffer layout shared by all Wildcat targets and the IMEM base and size for Nord. Default CFG_QCOM_DIAG_LOG to CFG_TEE_CORE_DEBUG so that the buffer is enabled on debug builds. Change-Id: I440a6aeb25624e6c87877faad774478fb491dca2 Signed-off-by: Pawan Rai <pawarai@qti.qualcomm.com>
Cacao already carries IMEM_BASE and IMEM_SIZE in its target_config.h, and the Wildcat arch_config.h now defines the shared buffer layout (IMEM_DIAG_OFFSET, DIAG_SIZE, DIAG_BASE, DIAG_LOG_START_INFO). Default CFG_QCOM_DIAG_LOG to CFG_TEE_CORE_DEBUG so that the buffer is enabled on debug builds. Change-Id: Ia472203bda34c738e36e06b65326d42a83ee421d Signed-off-by: Pawan Rai <pawarai@qti.qualcomm.com>
Shikra already carries IMEM_BASE and IMEM_SIZE in its target_config.h. Add the shared buffer layout macros (IMEM_DIAG_OFFSET, DIAG_SIZE, DIAG_BASE, DIAG_LOG_START_INFO) to the Bruin arch_config.h, and default CFG_QCOM_DIAG_LOG to CFG_TEE_CORE_DEBUG so the buffer is enabled on debug builds. Change-Id: Ie924e5f56d80a4103be60c5061fbfeadb69b5635 Signed-off-by: Pawan Rai <pawarai@qti.qualcomm.com>
Parse the OP-TEE diagnostic ring buffer written into IMEM by diag_log.c. Handles full RAM dumps (OCIMEM.BIN) with either a known DIAG_BASE offset (--offset) or automatic magic-scan mode (--scan), as well as pre-extracted DIAG region slices. Change-Id: I49a1145c9983d32b2c3ac8b50a6ec4916de606e0 Signed-off-by: Pawan Rai <pawarai@qti.qualcomm.com>
pawarai123
force-pushed
the
diag-log
branch
from
September 15, 2026 16:43
ad61c7f to
dd8a3c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.