Conversation
|
Duplicate PR for #50, please update the existing PR where review has happened. |
|
this is duplicate PR for #50 |
508175e to
bf0c5bb
Compare
b1f05f1 to
b21496d
Compare
rehman688
left a comment
rehman688
left a comment
There was a problem hiding this comment.
Tested on Nord and Shikra platforms. CSRNG functionality is working as expected.
rehman688
left a comment
rehman688
left a comment
There was a problem hiding this comment.
Tested on Nord and Shikra platforms. CSRNG functionality is working as expected.
|
How is this PR different from #66? |
|
I accidentally closed the PR. I'll reopen it. |
| #define QCOM_RNG_REG_BASE UL(0x010D0000) | ||
| #define QCOM_RNG_REG_SIZE UL(0x00020000) | ||
| #define QCOM_RNG_DATA_OUT 0x1000 | ||
| #define QCOM_RNG_STATUS 0x1004 |
There was a problem hiding this comment.
Why these macros which are same for Hoya are moved out of arch_config.h?
There was a problem hiding this comment.
For other targets like Nord and Shikra, the RNG base address is defined in their respective target_config.h files. To maintain consistency across all targets.
| #define QCOM_RNG_REG_BASE UL(0x010C0000) | ||
| #define QCOM_RNG_REG_SIZE UL(0x2000) | ||
| #define QCOM_RNG_DATA_OUT 0x1000 | ||
| #define QCOM_RNG_STATUS 0x1004 |
There was a problem hiding this comment.
Any reason why QCOM_RNG_REG_SIZE, QCOM_RNG_DATA_OUT and QCOM_RNG_STATUS can't be part of the CSPRNG driver?
There was a problem hiding this comment.
I was concerned that these register offsets might differ across targets. I now realize that the offsets are the same for all supported targets, so I'm moving these macros back into the CSRNG driver.
| #define QCOM_RNG_REG_BASE UL(0x04450000) | ||
| #define QCOM_RNG_REG_SIZE UL(0x00020000) | ||
| #define QCOM_RNG_DATA_OUT 0x1000 | ||
| #define QCOM_RNG_STATUS 0x1004 |
Add support for the Qualcomm CSRNG driver on Nord and Shikra platforms. Introduce the required platform-specific handling to enable CSRNG access from OP-TEE. Validation: - Build verified on Nord - Build verified on Shikra - CSRNG functionality validated on both platforms Signed-off-by: mrehman <mrehman@qti.qualcomm.com>
Enable CSRNG support for the Nord platform. Add the required platform configuration to expose the CSRNG driver to OP-TEE. Validation: - Build verified on Nord - CSRNG functionality validated on Nord Signed-off-by: mrehman <mrehman@qti.qualcomm.com>
Enable CSRNG support for the Shikra platform. Add the required platform configuration to expose the CSRNG driver to OP-TEE. Validation: - Build verified on Shikra - CSRNG functionality validated on Shikra Signed-off-by: mrehman <mrehman@qti.qualcomm.com>
Move the PRNG base address definition from the common Hoya configuration into the platform-specific target configurations. This avoids macro redefinition warnings and allows platform-specific PRNG base addresses to be maintained independently for Kodiak and Lemans. Validation: - Build verified on Kodiak - Build verified on Lemans Signed-off-by: mrehman <mrehman@qti.qualcomm.com>
b21496d to
3a84575
Compare
3 participants
This series enables CSRNG (PRNG) support on Qualcomm platforms.
Changes included:
Validation:
Commit Breakdown:
AI Usage:
No AI-generated code was used in this change set.