drivers: qcom: add chipinfo driver - #70
Vinod Kumar Amanaganti (vinod-amanaganti) wants to merge 1 commit into
Conversation
Add a Qualcomm Chipinfo driver to provide SoC identification. The driver retrieves SoC-specific information from shared memory and exposes a common interface for Qualcomm clients. Depends on: PR qualcomm-linux#51
|
Sumit Garg (@b49020) could you please review this? |
| QTI_CHIPINFO_ID_SM_HAWI_AS_MAILI = 755, | ||
|
|
||
| QTI_CHIPINFO_NUM_IDS, | ||
| QTI_CHIPINFO_ID_32BITS = 0x7FFFFFF |
There was a problem hiding this comment.
QTI_CHIPINFO_PART_32BITS = 0x7FFFFFFF (seven Fs). This is 0x7FFFFFF, with six Fs. Is this intentional?
| QTI_CHIPINFO_FAMILY_MAILI = 173, | ||
|
|
||
| QTI_CHIPINFO_NUM_FAMILIES, | ||
| QTI_CHIPINFO_FAMILY_32BITS = 0x7FFFFFF |
There was a problem hiding this comment.
hl5746
left a comment
hl5746
left a comment
There was a problem hiding this comment.
This breaks build on Nord:
CC out/arm-plat-qcom/core/drivers/qcom/chipinfo/chipinfo.o
core/drivers/qcom/chipinfo/chipinfo.c:12:10: fatal error: drivers/qcom/smem/smem.h: No such file or directory
| (uint32_t)part >= QTI_CHIPINFO_NUM_PARTS) | ||
| return false; | ||
|
|
||
| if (part_idx == 0U) { |
There was a problem hiding this comment.
This assigns to part idx 0 special behaviour, implying that part_idx is 1-based, but in def of struct qti_platforminfo_part_info (platforminfodefs.h:55) it's defined as 0-based.
Sumit Garg (b49020)
left a comment
Sumit Garg (b49020)
left a comment
There was a problem hiding this comment.
End-to-end use-case missing, please clarify how this driver is going to be used for Nord.
|
Please follow below guideline to avoid basic query from maintainer: [chipset name] [driver name] : [Dependent PR] : signed-off : After testing is complete, the author must paste the test log in the "commit comment". |
4 participants
drivers: qcom: add chipinfo driver
Add a Qualcomm ChipInfo driver used to retrieve SoC identification
information from shared memory.
The driver exposes a common API that allows Qualcomm clients to
query chip family, device ID, and version information.
Depends on: PR #51