Topic/shivsanj msgid msgram fix - #73
Draft
Shivam Sanjay (shvm-ap) wants to merge 2 commits into
Draft
Shivam Sanjay (shvm-ap) wants to merge 2 commits into
Shivam Sanjay (shvm-ap) wants to merge 2 commits into
Conversation
The RPMh command MSGID encodes a MSG_LENGTH field describing the payload length, in bytes, of the command. This field was hardcoded to 1 which is leading to unpredictable behavior on the AOP side (including the command never being acknowledged, causing timeouts). Changing it to 8 (the correct length for the single 32-bit data word every RPMh command carries), introducing macros MSGID_MSG_LENGTH_VALUE, MSGID_WRITE, MSGID_READ so the expected encoding is explicit. Using MSGID_WRITE since it's a write command. Signed-off-by: Shivam Sanjay <shivsanj@qti.qualcomm.com>
MSG_RAM_SECTION_SIZE was hardcoded to 0x10000 for all targets, but nord's actual AOP section size is 0x1000 (MSG_RAM_DRV_SIZE 0x400 + MSG_RAM_GAP_SIZE 0xC00), causing the wrong offset to be computed. Move MSG_RAM_SECTION_SIZE into a per-flavor header: 0x10000 for kodiak/lemans (unchanged), 0x1000 for nord. Offset is now 15 * MSG_RAM_SECTION_SIZE. Verified on hardware for nord, build verified for all three targets.
Shivam Sanjay (shvm-ap)
marked this pull request as draft
September 17, 2026 13:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic fixes required on Nord.
Unit tested on Nord device on qcom-next branch.
Not tested on device on this branch because the dependency commits are not present.
The objective is to unblock the release.