Add Nord RPMh driver support; Lemans target specific rpmh config; fix MSD_ID flag and length - #74
Open
Shivam Sanjay (shvm-ap) wants to merge 3 commits into
Conversation
The RPMh command MSGID encodes a MSG_LENGTH field describing the payload length, in bytes, of the command. This field was hardcoded to 1 which is leading to unpredictable behavior on the AOP side (including the command never being acknowledged, causing timeouts). Changing it to 8 (the correct length for the single 32-bit data word every RPMh command carries), introducing macros MSGID_MSG_LENGTH_VALUE, MSGID_WRITE, MSGID_READ so the expected encoding is explicit. Using MSGID_WRITE since it's a write command. Signed-off-by: Shivam Sanjay <shivsanj@qti.qualcomm.com>
Adding Nord support, following target specific RMPh configuration structure. Unit tested on Nord device.
Shivam Sanjay (shvm-ap)
marked this pull request as draft
September 17, 2026 13:15
Shivam Sanjay (shvm-ap)
changed the title
Shivam Sanjay (shvm-ap)
changed the title
Shivam Sanjay (shvm-ap)
marked this pull request as ready for review
September 17, 2026 15:48
IDineshChoudhary
approved these changes
Sep 20, 2026
IDineshChoudhary
left a comment
IDineshChoudhary
left a comment
There was a problem hiding this comment.
This is for staging branch - explicit reviews ongoing on qcom-next and optee upstream.
Let's merge it to unblock depedent drivers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding RPMh driver support for Nord following target specific Rpmh config as in Lemans.
Fixing MSG_ID Flag (using WRITE flag now correctly), and Length (earlier length was 1 which
was causing undefined behaviour, now using the correct value of 8).
Fixing Boot cookie polling timeout due to reading wrong address.
Bootup tested on Nord device. Build tested for Lemans.