Promotion to 1.0.0 - #10
Closed
qcom-service-bot wants to merge 249 commits into
Closed
qcom-service-bot wants to merge 249 commits into
qcom-service-bot wants to merge 249 commits into
Conversation
Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Signed-off-by: quic-aditrath <quic_aditrath@quicinc.com>
Add spf header files required to support Congestion Audio Buffer and Jitter buffer module API. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Change in QACT online mode are temporary and shouldn't persist calibration or tag data to the *.acdbdelta files. Update Ats Online Service to v1.4 and add v2 APIs for SET Tag, Non-persist & Persist calibration. The new SET APIs introduce a should_persist flag that allows QACT to decide whether data should be persisted to the delta files. Set default value for this flag to false for v1 and v2 API's. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Adds support for the new ACDB_CMD_GET_PROC_TAGGED_MODULES command for setting up datapath read/write endpoints. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Add null check for allocated buffer handle to avoid potential null pointer dereference during playback/record usecase with shmem map API failing in ADSP. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
As num_buff has type uint32_t, update data type for number of buffer iterator from uint8_t to uint32_t in gsl_clear_internal_buf() to avoid possible integer overflow. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Update response buffer to NULL and buffer size to 0 when AR_ETIMEOUT return code is received for PRM_CMD_REQUEST_HW_RSC command to spf. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Add check for number of CKVs before allocating memory for CKV key vector in gsl_graph_set_tagged_custom_config() function to avoid possible graph open failure due to memory allocation for 0 CKV in raw mode. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
In scenarios like APM_CMD_SHARED_MEM_MAP_REGIONS command timeout, error handling in function gsl_shmem_handle_rsp() is done after processing the response, which can lead to un-expected behavior. Update to move error handling before processing the response to handle error's properly. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
New structures gsl_key_vector_array, gsl_key_vector_list, gsl_tag_key_vector and gsl_tag_key_vector_list are added and their corresponding functions - gsl_get_graph_tkvs, gsl_get_graph_ckvs, gsl_get_driver_module_kvs, gsl_get_supported_gkvs have been modified accordingly. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Add null check for log_pkt and log_pkt_ptr in ar_data_log_submit() and _log_alloc_pkt() respectively. Update datatype for num_channels and iterator variables from uint32_t to uint16_t in _log_pcm_pkt() function. Add proper type cast and remove unused variables. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
… reset. Destroy acdb_client_lock mutex lock during acdb context manager reset to prevent memory leak. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Add null check for graph key vector values in AcdbCmnGetGraph() and LogKeyVector() to prevent possible null pointer dereference in scenarios when graph open fails after coming out of hibernates. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
In osal add file attribute properly based on operation Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
… RTGM Reverted the stub implementation of ar_osal_log_pkt as RTM workflow is unable to cache the QACT info to support RTGM. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Add changes to fix uninitialized variable & null pointer dereference issue. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Update hw_intf_cmn_api to include silence detection feature definitions and structures. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Add header file for multi modal activation. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
On handset device, AGM is merged into audio HAL service by default, then ssr and crash should always be triggered through audio property. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Update to remove h2xml flag for detections variable. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
GPR receiver thread exits when it receives an interrupti and poll API return error. Continue polling on fd, if poll fails due to EINTR. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
For the very first SSR request, as the restart_cnt is still 0, this can bypass the check for duplicated restart request. Fix it by removing the restart_cnt check, so this can esnure no repeated triggering during short time. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Change log level for non erroneous messages. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
GPR packet token field is used by APM modules when raising events. GSL update for debug tokens created an issue, as the modules need to to match the same tokens to events. GSL previously was always setting token to 0 in for events. This patch removes tokens specifically for the opcode which causes the issue. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Fix 'ar_shmem_lock' is not unlocked before return Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Adding new parameters in pcm data use case's structure asps_pcm_data_usecase_register_payload_t to provide additional capabilities for clients to configure the pcm data use case. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Add header files for us tone renderer. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Static analysis revealed that persist_cal_idx, derived from iterating over sg->num_proc_ids, may exceed the valid bounds of the persist_cal_data_per_proc array. This change adds explicit validation to ensure that sg->num_proc_ids never exceeds the array’s capacity before iterating, preventing invalid persist_cal_idx values from propagating into subgraph-level functions. Signed-off-by: ffrancis <ffrancis@qti.qualcomm.com>
Add history_buffer_api in spf_sources Signed-off-by: ffrancis <ffrancis@qti.qualcomm.com>
Commits included: args: gpr: Remove redundant NULL check args: Fix double free of global persist calibration data args: Fix NULL dereference caused by invalid old_node pointer args: Add bounds checking for persist_cal_idx to prevent out-of-bounds spf: Add necessary headers support to build
Clean up redundant header reference under ATS_USES_DUMMY_DIAG. Signed-off-by: Sairamreddy Bojja <sbojja@qti.qualcomm.com>
Use DIAG-specific headers when DIAG support is enabled by adding the USE_LIBDIAG_HEADERS compile flag. Drop -llog from linkage since it is no longer required. Update CI build options to disable dummy_diag and enable DIAG for consistent builds. Signed-off-by: Sairamreddy Bojja <sbojja@qti.qualcomm.com>
- Add VAD moduel header. - Updte SH_MEM module header, to enable header type param ID in SH_MEM endpoint module. Signed-off-by: ffrancis <ffrancis@qti.qualcomm.com>
args: Add VAD and SH_MEM module headers
Create stale-issues.yaml to align stale workflow with OSS best practices. - Mark issues/PRs as stale after 30 days - Notify maintainers when items become stale - Disable auto-closing of stale items - Ensure consistency with automation templates Signed-off-by: Sandhya Adavikolanu <sadaviko@qti.qualcomm.com>
Update mma_api to support configuration of synthetic detection in spf. Signed-off-by: ffrancis <ffrancis@qti.qualcomm.com>
An empty Delta files only containing a header with no data and the data size field being set to 0 bytes is invalid. It should be 4 bytes which includes the map count for an empty delta file. Added a validation check to prevent the crash Signed-off-by: Kofi Derrick Essilfie <kofie@qti.qualcomm.com>
Existing generic shared memory allocator is implemented based on the configuration which entire AudioReach stack, including the engine, runs in Linux userspace under single process. So, entire AudioReach stack would operate within the same virtual memory space. In order to enable SoC which has application processor and audio DSP exchanging data over physical shared memory, add a new Linux osal shared memory allocator which invokes DMA-BUF API to acquire shared memory from uncached physically contiguous memory region. Signed-off-by: ffrancis <ffrancis@qti.qualcomm.com>
Added new header files for head tracking and spatial audio modules Signed-off-by: ffrancis <ffrancis@qti.qualcomm.com>
Add conditional build flag to enable MDSP-specific audio functionality and DMA heap selection. Signed-off-by: ffrancis <ffrancis@qti.qualcomm.com>
Add Add miqster module header file for audio zoom Signed-off-by: ffrancis <ffrancis@qti.qualcomm.com>
ar_shmem_info_t.sys_id changed from uint8_t * to ar_shmem_proc_info * but ar_shmem_validate_sys_id() was not updated, causing an incompatible pointer type error under -Werror with linux-yocto 6.18. Update the parameter type and access proc_id in the validation loop. Signed-off-by: Aditya Rathi <aditrath@qti.qualcomm.com>
posix_memalign() carries __attribute__((warn_unused_result)); ignoring it triggers -Wunused-result, promoted to an error by -Werror. On failure the output pointer is left indeterminate, making the subsequent NULL check on vaddr unreliable. Check the return value and propagate AR_ENOMEMORY on failure. Signed-off-by: Aditya Rathi <aditrath@qti.qualcomm.com>
aml: Fix underflow crash caused by empty Delta files
Create a new thread for DLS that will wait for available DLS buffers to be sent to ADSP. This fixes a deadlock issue with DLS for systems using ADSP as the master process. Signed-off-by: Annemarie Porter <annemari@qti.qualcomm.com>
Without a %d specifier in the format string, the status argument passed to ATS_ERR is silently ignored, making failures harder to diagnose. Add the Error[%d]: prefix to expose the error code. Signed-off-by: Aditya Rathi <aditrath@qti.qualcomm.com>
ats/adie: Ensure error code is logged in ATS_ERR messages
dls: Add changes to enable DLS running on ADSP
osal: shmem: Fix sys_id type mismatch and handle posix_memalign return value
Switch trigger from pull_request_target to pull_request to improve security and align with standard GitHub Actions practices. Normalize YAML formatting and dependencies for clarity. [1] Simplify test matrix filtering by refining jq logic, validating JSON, and supporting both object and array formats. Persist the filtered matrix to test_matrix.json and upload it as an artifact. Replace inline LAVA trigger with trigger_lava_on_success workflow, which runs after a successful build, retrieves artifacts, extracts the build URL, and invokes LAVA tests with the prepared matrix. [1] AudioReach/audioreach-workflows#73 Signed-off-by: ffrancis <ffrancis@qti.qualcomm.com>
Switch pre-merge workflow to pull_request and add LAVA trigger flow
This commit pulls in upstream changes from 'v1.0.0' into the Debian packaging branch. Since upstream project might have content of their own in their .github/ folder (because they have CI stuff on their side), it's important to NOT pick up .github/ folder from upstream, and only leave the .github/ folder from debian packaging branch. The same applies to debian/ folder if upstream has one (which is rare but possible). This commit was generated automatically by qcom-build-utils/scripts/merge_debian_packaging_upstream. Signed-off-by: GitHub Service Bot <githubservice@qti.qualcomm.com>
Signed-off-by: GitHub Service Bot <githubservice@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated PR to test the promotion of this package repo to the upstream project version 1.0.0.
This PR merges the upstream changes from the upstream tag 'v1.0.0' into the debian/qcom-next branch, and updated the debian/changelog version to reflect this new version. Whatever was the distro version before (the part after the '-' in a version x.y.z-a), it has been reset to -1.
The upstream tag 'v1.0.0' has already been merged into the upstream/latest branch, and this PR merges that branch into debian/qcom-next.
In other words, this repo already contains the upstream changes in the upstream/latest branch, but the debian packaging is not yet updated to reflect this new upstream version. This is what this PR is doing.
The build-debian-package.yml workflow is triggered automatically in this PR to test the promotion by building the Debian package with the updated upstream code and packaging.
If something breaks due to the promotion of the upstream sources to this new revision, this is the moment where you can checkout this branch locally, make changes and push additional commits to make the build pass.
For example: you may need to add patches to the debian/patches/ folder to fix issues that were introduced upstream since the last version we were using, such as a new binary created upstream that needs to be packaged, or a build system change that requires updating the debian/rules file, etc.
Once you are satisfied with the changes, click the 'Merge' button below to finalize the promotion.
Note: Due to the nature of the graph that is attempted to be merged, only a merge (and therefore the creation of a merge commit) with the 'Merge' button will work.
Attempting second option 'Squash and Merge' or 'Rebase and Merge' will fail. This is because in both of these two cases, this head branch woule need to be cleanly rebasable onto the base branch, which is not the case here.
This generated diagram attemps to illustrate what happened and what will happen when you click the 'Merge' button below.:
The commit tagged 'upstream/1.0.0' is a merge from the upstream tag v1.0.0 commit where in addition,
special git wizardry happened to perform a special filtering of any potential upstream .github/ and debian/ folders have been filtered out,
and only homonym folders from the debian/qcom-next branch have been kept.
It represents the merge of the upstream/latest branch into debian/qcom-next.
--- config: themeVariables: 'gitInv2': '#ff0000' gitGraph: parallelCommits: true rotateCommitLabel: true --- gitGraph BT: branch debian/qcom-next order: 1 branch upstream-main order: 4 branch upstream/latest order: 3 checkout main commit id: 'Unrelated history: workflows, doc' checkout upstream-main commit checkout upstream-main commit commit id: 'release' tag: 'v1.0.0' checkout upstream/latest commit id: 'previous stuff' merge upstream-main id: 'Filtered .github/debian folders' tag: 'upstream/1.0.0' checkout debian/qcom-next commit commit commit branch debian/pr/1.0.0-1 order: 2 merge upstream/latest id: 'Merged Upstream' commit id: 'Changelog version update' type: HIGHLIGHT