debian: Fix udev rule triggering - #92
Michaël Blanc (mika-blanc) wants to merge 1 commit into
Conversation
|
This PR is to fix same issue: #86 |
d88e4fa to
b349b98
Compare
|
Ok, I removed the fastrpc group creation part of my commit and only kept the udev rule triggering part, which users installing fastrpc-support might expect so they don't have to reboot to use the dev nodes. |
Michaël Blanc (mika-blanc)
changed the title
|
Waiting for #86 to be merged first. |
Please add Signed-off-by tag to the commit
Loïc Minier (lool)
left a comment
Loïc Minier (lool)
left a comment
There was a problem hiding this comment.
Thanks Michaël Blanc (@mika-blanc), that's an interesting idea!
I've left a few review comments; you can ignore the one on "which"
I'm not 100% this change is actually needed though: doesn't udevd watch changes to /usr/lib/udev/rules.d?
| #DEBHELPER# | ||
|
|
||
| if [ "$1" = "configure" ]; then | ||
| if which udevadm >/dev/null 2>&1 ; then |
There was a problem hiding this comment.
"which" is fine, consider "command" as a shell builtin instead of an external command
There was a problem hiding this comment.
I'd rather use "which", "command" triggers research in apt if the command is not found on Ubuntu. Instead I simplified the command to "which -s" for silent operation.
|
I've tweaked description to drop the sysuser parts. |
Most users expect their fastrpc use cases to work after installation of fastrpc-support without retriggered udev rules, so we trigger the fastrpc udev rules in the postinst script (dh_installudev doesn't do it).
b349b98 to
e120918
Compare
Yes, udevd reloads rules on change, so I removed the "--reload-rules" command altogether. However, triggering these rules for |
Loïc Minier (lool)
left a comment
Loïc Minier (lool)
left a comment
There was a problem hiding this comment.
I've left one more minor nit, but I mostly have one important request: would you mind adding a Signed-off-by? (git commit --amend -s)
Shoudi Li (@shoudil) otherwise ready for merging, I'd like the same change in the debian/latest though, and this branch depends on the other changes, so perhaps worth rebasing on top of debian/latest?
| #!/bin/sh | ||
| set -e | ||
|
|
||
| #DEBHELPER# |
There was a problem hiding this comment.
would perhaps be nice to underline that this needs to be before the snippet below
(FYI, this branch needs to land after a rebase/merge on top of debian/latest, otherwise dh-sequence-installsysusers is missing. – Cc: Shoudi Li (@shoudil))
4 participants
Most users expect their fastrpc use cases to work after installation of fastrpc-support without retriggered udev rules, so we trigger fastrpc udev rules in the postinst script (dh_installudev doesn't do it).