ci: migrate to reusable test workflow - #405
Milosz Wasilewski (mwasilew) wants to merge 1 commit into
Conversation
|
This PR is stale. Add a nice message, can mention maintainers or maintainer team to draw attention |
|
Loïc Minier (@lool) I'll be picking this up soon |
d891d43 to
5248af4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| test-debian: | ||
| needs: [prepare-env] | ||
| name: "Test nodistro" | ||
| uses: mwasilew/meta-qcom/.github/workflows/test-distro.yml@debian-support |
| needs: [prepare-env] | ||
| name: "Test nodistro" | ||
| uses: mwasilew/meta-qcom/.github/workflows/test-distro.yml@debian-support | ||
| secrets: inherit |
Christopher Obbard (obbardc)
changed the title
Christopher Obbard (obbardc)
left a comment
Christopher Obbard (obbardc)
left a comment
There was a problem hiding this comment.
Looks good so far, some small thoughts!
| # every board but monaco-arduino-monza; see | ||
| # https://github.com/qualcomm-linux/qcom-deb-images/issues/537 | ||
| boards_exclude: '["monaco-arduino-monza"]' | ||
| boards_include: 'glymur-crd,lemans-evk,monaco-evk,qcs615-ride,qcs6490-rb3gen2-vision-kit,qcs8300-ride,qrb2210-rb1' |
There was a problem hiding this comment.
why not keep boards_exclude ?
There was a problem hiding this comment.
oh, i see you removed boards_exclude, see later comment about that.
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| - name: Print trigger | ||
| - name: "Print ref" |
There was a problem hiding this comment.
| - name: "Print ref" | |
| - name: Print lava-test-plans ref |
or similar ?
There was a problem hiding this comment.
done
| # never overwritten, so scope them by suite + run attempt instead. | ||
| test_job_file_name_prefix: ${{ inputs.suite }}-${{ github.run_attempt }}- | ||
| test-debian: | ||
| needs: [prepare-env] |
There was a problem hiding this comment.
remove [] from the needs, not needed
| test_job_file_name_prefix: ${{ inputs.suite }}-${{ github.run_attempt }}- | ||
| test-debian: | ||
| needs: [prepare-env] | ||
| name: "Test nodistro" |
There was a problem hiding this comment.
remove "" from the name ?
c01a192 to
14d1e99
Compare
Replace current testing setup with reusable test-distro.yml workflow from meta-qcom. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
14d1e99 to
f9a1954
Compare
|
Milosz Wasilewski (@mwasilew) Christopher Obbard (@obbardc) where are we with this PR? I see some resolved, and some unresolved comments, and it's still draft, so I'm not clear on who is expected to act next |
|
Loïc Minier (@lool) I think it should remain in draft for now. I'm trying to get the reusable workflow merged into qualcomm/reusable-workflows repository. There are a few hurdles on the way (like pinning the action versions). I'll try to proceed as quickly as possible. This is on top of my todo list. |
4 participants
Replace current testing setup with reusable test-distro.yml workflow from meta-qcom.
See also qualcomm-linux/lava-test-plans#30