Add build-time option for UBWC video formats - #34
Open
Ali Erdinc Koroglu (aekoroglu) wants to merge 1 commit into
Open
Ali Erdinc Koroglu (aekoroglu) wants to merge 1 commit into
Ali Erdinc Koroglu (aekoroglu) wants to merge 1 commit into
Conversation
The NV12_Q08C and NV12_Q10LE32C formats are not part of upstream GStreamer, they come from the Qualcomm patch set. Referencing them unconditionally breaks the build against an unpatched GStreamer. Add the ENABLE_GST_UBWC_VIDEO_FORMATS CMake option, defaulting to ON to keep the existing behaviour. When it is on, the HAVE_GST_VIDEO_FORMAT_* compile definitions are set and the UBWC formats are advertised in the vcomposer and vsplit caps; when off, they are compiled out. Signed-off-by: Ali Erdinc Koroglu <ali.koroglu@oss.qualcomm.com>
Ali Erdinc Koroglu (aekoroglu)
requested review from
NaveenCherukuri (CherukuriNaveenQC) and
GirishKadirisani
as code owners
August 21, 2026 07:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NV12_Q08C and NV12_Q10LE32C formats are not part of upstream GStreamer, they come from the Qualcomm patch set. Referencing them unconditionally breaks the build against an unpatched GStreamer.
Add the ENABLE_GST_UBWC_VIDEO_FORMATS CMake option, defaulting to ON to keep the existing behaviour. When it is on, the HAVE_GST_VIDEO_FORMAT_* compile definitions are set and the UBWC formats are advertised in the vcomposer and vsplit caps; when off, they are compiled out.