libminkadaptor: define Object_OP_version - #90
Open
Ali Erdinc Koroglu (aekoroglu) wants to merge 1 commit into
Open
Ali Erdinc Koroglu (aekoroglu) wants to merge 1 commit into
Ali Erdinc Koroglu (aekoroglu) wants to merge 1 commit into
Conversation
Harshal Dev (harshaldev27)
approved these changes
Aug 22, 2026
Contributor
|
Can you please check the commit message check which is failing? We generally request the commit messages to be wrapped at 75 characters. |
mink-idl-compiler v0.3.0 added interface versioning. From that release
onward, every generated interface gets an I<Interface>_api_version()
helper and a matching `case Object_OP_version:` arm in the
I<Interface>_DEFINE_INVOKE skeleton macro.
libminkadaptor/include/object.h defines only Object_OP_release and
Object_OP_retain, so every generated header fails to compile:
error: 'Object_OP_version' undeclared (first use in this function);
did you mean 'Object_OP_retain'?
Define it, matching the reference object.h that mink-idl-compiler builds
its own integration tests against (tests/c/object.h). The value derives
from ObjectOp_LOCAL rather than ObjectOp_METHOD_MASK, placing it in the
reserved range alongside release/retain, so it does not affect positional
method op codes.
Fixes: qualcomm#89
Signed-off-by: Ali Erdinc Koroglu <ali.koroglu@oss.qualcomm.com>
Ali Erdinc Koroglu (aekoroglu)
force-pushed
the
idlc
branch
from
August 25, 2026 15:36
2490ffa to
ca6ae49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mink-idl-compiler v0.3.0 added interface versioning. From that release onward, every generated interface gets an I_api_version() helper and a matching
case Object_OP_version:arm in the I_DEFINE_INVOKE skeleton macro.libminkadaptor/include/object.h defines only Object_OP_release and Object_OP_retain, so every generated header fails to compile:
error: 'Object_OP_version' undeclared (first use in this function);
did you mean 'Object_OP_retain'?
Define it, matching the reference object.h that mink-idl-compiler builds its own integration tests against (tests/c/object.h). The value derives from ObjectOp_LOCAL rather than ObjectOp_METHOD_MASK, placing it in the reserved range alongside release/retain, so it does not affect positional method op codes.
Fixes: #89