filter: fix absolute registry path access error in the Windows 11 26H1 HLK#67
Open
Chenxi Han (5656hcx) wants to merge 2 commits into
Open
filter: fix absolute registry path access error in the Windows 11 26H1 HLK#67Chenxi Han (5656hcx) wants to merge 2 commits into
Chenxi Han (5656hcx) wants to merge 2 commits into
Conversation
Signed-off-by: Chenxi Han <chehan@qti.qualcomm.com>
…vicePropertyData Signed-off-by: Chenxi Han <chehan@qti.qualcomm.com>
Chenxi Han (5656hcx)
requested review from
hangzqcom,
rohimish-qc,
Shashank Arora (shasaror) and
tejas27 (tejas-sharma27)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplified friendly-name registration in the qcfilter driver by replacing the outdated registry approach with the
IoSetDevicePropertyDatakernel API. Also removed unreferenced variables, functions, headers from all project files.Changes
qcfilter.cQCFilterSetFriendlyName(...)call inQCFilterCreateFriendlyNamewithIoSetDevicePropertyData(PDO, &DEVPKEY_Device_FriendlyName, ...)qcfilter.cQCFilterSetFriendlyNamefunction body (~270 lines)qcfilter.hQCFilterSetFriendlyNameprototypeBehavior
QCFilterCreateFriendlyNamestill first checks for an existingFriendlyNameproperty; only if absent does it construct and set one.IoSetDevicePropertyDatais available on Windows 8 and later (NTDDI_WIN8), which is consistent with the driver's existing use ofExAllocatePoolZeroandIoInitializeRemoveLockwith 4-parameter signature.Test
Local installation correctly displayed device name with instance id:
Qualcomm USB Composite Device 90DB (0018)The device hardware key (
Computer\HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Enum\USB\VID_05C6&PID_90DB\) also contains the correctfriendlyName:Qualcomm USB Composite Device 90DB (0018)