Update source code 12/09/2026 [Batch1] - #17
Merged
Merged
Conversation
gst_ml_qnn_engine_free() no longer clears the input/output Qnn_Tensor_t clientBuf.data/dataSize before releasing graph info and the QNN system context. These tensors alias memory owned by the system context handle (for cached/DLC models) or the model library, and their clientBuf still points at the last GstBuffer used in execute() at teardown time. Freeing the system context while that stale buffer pointer is still set caused libQnnSystem.so to crash inside its internal free() during QnnSystemContext_free(). This clearing step existed prior to "qtimlqnn: Add support for loading model graph from DLC" (a992eeaf), which dropped it while refactoring the cached/uncached graph teardown into the FreeGraph/g_free branches. Restore it, iterating graph_infos[0] before releasing graph info, as before. Signed-off-by: Pratik Pachange <ppachang@qti.qualcomm.com> Signed-off-by: Girish K <girik@qti.qualcomm.com>
GirishKadirisani
requested a review
from NaveenCherukuri (CherukuriNaveenQC)
as a code owner
September 12, 2026 04:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the change: