qmi-framework: Unify API naming and error handling conventions - #9
Merged
Deepak Kumar Singh (quic-deesin) merged 1 commit intoDec 9, 2025
Conversation
Standardize the QMI Common Client Interface (CCI) and QMI Common Service Interface (CSI) APIs to follow consistent naming patterns and error handling approaches. This change improves code readability, maintainability, and developer experience by: 1. Renaming files to follow consistent naming patterns: - qmi_client.h → qmi_cci.h - qcsi.h → qmi_csi.h 2. Standardizing API function names with consistent prefixes: - Client APIs use qmi_cci_* prefix (e.g., qmi_cci_init, qmi_cci_send_msg) - Service APIs use qmi_csi_* prefix (e.g., qmi_csi_register, qmi_csi_send_resp) 3. Converting error code definitions from preprocessor macros to enums in the client interface for improved type safety and debugging, matching the approach already used in the service interface. Signed-off-by: Pranav Mahesh Phansalkar <pranav.phansalkar@oss.qualcomm.com>
Deepak Kumar Singh (quic-deesin)
approved these changes
Dec 9, 2025
Deepak Kumar Singh (quic-deesin)
merged commit Dec 9, 2025
0e298b9
into
qualcomm:development
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize the QMI Common Client Interface (CCI) and QMI Common Service Interface (CSI) APIs to follow consistent naming patterns and error handling approaches. This change improves code readability, maintainability, and developer experience by:
Renaming files to follow consistent naming patterns:
Standardizing API function names with consistent prefixes:
Converting error code definitions from preprocessor macros to enums in the client interface for improved type safety and debugging, matching the approach already used in the service interface.